Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: rename zkevm-llvm to zksync-llvm #27

Conversation

antonbaliasnikov
Copy link
Contributor

@antonbaliasnikov antonbaliasnikov commented May 8, 2024

What ❔

  • Rename zkevm-llvm to zksync-llvm
  • Make tests independent from LLVM commit sha

Why ❔

Fixes CPR-1674

To correspond to our new naming conventions and stabilize tests execution.

Checklist

  • PR title corresponds to the body of PR.
  • Documentation comments have been added / updated.
  • Code has been formatted via cargo fmt and checked with cargo clippy.

@antonbaliasnikov antonbaliasnikov force-pushed the aba-cpr-1674-make-compiler-builder-unit-tests-independent-from-the-commit branch from 4e5f539 to b50980a Compare May 8, 2024 11:37
@antonbaliasnikov
Copy link
Contributor Author

antonbaliasnikov commented May 8, 2024

@antonbaliasnikov antonbaliasnikov marked this pull request as ready for review May 8, 2024 12:09
@antonbaliasnikov antonbaliasnikov force-pushed the aba-cpr-1674-make-compiler-builder-unit-tests-independent-from-the-commit branch from 0ba5b39 to 82cadef Compare May 8, 2024 13:07
@antonbaliasnikov antonbaliasnikov changed the title [DO NOT MERGE] feat!: rename zkevm-llvm to zksync-llvm feat!: rename zkevm-llvm to zksync-llvm May 8, 2024
hedgar2017
hedgar2017 previously approved these changes May 8, 2024
@hedgar2017
Copy link
Collaborator

Hm, the MUSL downloading failed again somehow.

@antonbaliasnikov
Copy link
Contributor Author

Hm, the MUSL downloading failed again somehow.

Yeah :(

My logic was not correct, this should fix:
#28

@hedgar2017 hedgar2017 merged commit 51b3bf9 into main May 9, 2024
11 checks passed
@hedgar2017 hedgar2017 deleted the aba-cpr-1674-make-compiler-builder-unit-tests-independent-from-the-commit branch May 9, 2024 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants