Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fix Goerli mentioned/links/formatting of lists/ remove links to Notion and Linear #247

Conversation

olehbairak
Copy link
Contributor

@olehbairak olehbairak commented Apr 17, 2024

What ❔

List of actions:

  • review goerli link
  • remove Notion pages and Linear links
  • check that links are up-to-date
  • listing formatting (e.g. for Tokens test cases)

Why ❔

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.

@olehbairak olehbairak added the documentation Improvements or additions to documentation label Apr 17, 2024
@olehbairak olehbairak self-assigned this Apr 17, 2024
@olehbairak olehbairak requested a review from pcheremu April 17, 2024 14:01
@olehbairak olehbairak marked this pull request as ready for review April 17, 2024 14:02
Copy link

API E2E Test Results

207 tests  ±0   207 ✅ ±0   18s ⏱️ -3s
 14 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit 1a5af29. ± Comparison against base commit 549be8c.

1 similar comment
Copy link

API E2E Test Results

207 tests  ±0   207 ✅ ±0   18s ⏱️ -3s
 14 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit 1a5af29. ± Comparison against base commit 549be8c.

Copy link

API E2E Test Results

207 tests  ±0   207 ✅ ±0   20s ⏱️ -1s
 14 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit 1a5af29. ± Comparison against base commit 549be8c.

Copy link

API E2E Test Results

207 tests  ±0   207 ✅ ±0   19s ⏱️ -2s
 14 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit 1a5af29. ± Comparison against base commit 549be8c.

Copy link

github-actions bot commented Apr 17, 2024

API E2E Test Results

207 tests  ±0   207 ✅ ±0   20s ⏱️ -1s
 14 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit 78ad85c. ± Comparison against base commit 549be8c.

♻️ This comment has been updated with latest results.

Copy link

Unit Test Results

    4 files  ±0    263 suites  ±0   11m 2s ⏱️ +4s
2 081 tests ±0  2 080 ✅ ±0  1 💤 ±0  0 ❌ ±0 
2 289 runs  ±0  2 288 ✅ ±0  1 💤 ±0  0 ❌ ±0 

Results for commit 1a5af29. ± Comparison against base commit 549be8c.

Copy link

github-actions bot commented Apr 17, 2024

Unit Test Results

    4 files  ±0    263 suites  ±0   11m 9s ⏱️ +11s
2 081 tests ±0  2 080 ✅ ±0  1 💤 ±0  0 ❌ ±0 
2 289 runs  ±0  2 288 ✅ ±0  1 💤 ±0  0 ❌ ±0 

Results for commit 2a7259c. ± Comparison against base commit 549be8c.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Apr 17, 2024

Visit the preview URL for this PR (updated for commit 78ad85c):

(expires Wed, 24 Apr 2024 14:33:41 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: e508f9012944951194447cb8885950b451a24403

@@ -5,7 +5,7 @@ tags: ['Full test', 'Navigation', 'Network', 'Smoke test', 'Automated']
# id562 Networks navigation Staging - Common - Navigation to zkSync Era Testnet

## Description
- Preconditions: user opens any BE page with zkSync Era Mainnet or Goerli (Stage2) network selected
- Preconditions: user opens any BE page with zkSync Era Mainnet or sepolia (Stage2) network selected
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will be better to start from a capital letter.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@@ -5,7 +5,7 @@ tags: ['Full test', 'Navigation', 'Network', 'Smoke test', 'Automated']
# id563 Networks navigation Staging - Common - Navigation to Mainnet

## Description
- Preconditions: user opens any BE page with zkSync Era Testnet or Goerli (Stage2) network selected
- Preconditions: user opens any BE page with zkSync Era Testnet or sepolia (Stage2) network selected
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@pcheremu pcheremu merged commit 41dcac7 into QA-613-add-docusaurus-docs-project Apr 17, 2024
15 checks passed
@pcheremu pcheremu deleted the oleh-bairak-qa-807-docusaurus-remove-goerli-links-update-links-to-tx-simple branch April 17, 2024 14:30
pcheremu pushed a commit that referenced this pull request May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants