Skip to content

Bump Ruma/uniffi - #6947

Open
poljar wants to merge 2 commits into
mainfrom
poljar/bump-uniffi
Open

Bump Ruma/uniffi#6947
poljar wants to merge 2 commits into
mainfrom
poljar/bump-uniffi

Conversation

@poljar

@poljar poljar commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

Bumping Ruma and Uniffi.

Since Ruma depends on 0.32.0 of Uniffi, we need to bump to that version as well.

At the same time testing matrix-org/complement-crypto#275.

@poljar
poljar requested review from a team as code owners August 31, 2026 12:03
@poljar
poljar requested review from Hywan and richvdh and removed request for a team August 31, 2026 12:03

@Hywan Hywan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to me.

@codecov

codecov Bot commented Aug 31, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.17%. Comparing base (97d7c92) to head (513a02f).
⚠️ Report is 36 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6947   +/-   ##
=======================================
  Coverage   90.17%   90.17%           
=======================================
  Files         408      408           
  Lines      116979   116979           
  Branches   116979   116979           
=======================================
+ Hits       105481   105491   +10     
+ Misses       7548     7547    -1     
+ Partials     3950     3941    -9     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

@codspeed-hq

codspeed-hq Bot commented Aug 31, 2026

Copy link
Copy Markdown

Merging this PR will improve performance by 68.87%

⚡ 1 improved benchmark
✅ 49 untouched benchmarks

Performance Changes

Benchmark BASE HEAD Efficiency
Restore session [memory store] 596.7 ms 353.4 ms +68.87%

Tip

Curious why performance improved? Comment @codspeedbot explain why performance improved on this PR, or directly use the CodSpeed MCP with your agent.


Comparing poljar/bump-uniffi (513a02f) with main (bdcdd3b)

Open in CodSpeed

@poljar
poljar force-pushed the poljar/bump-uniffi branch from 008f9d3 to 50670a4 Compare August 31, 2026 16:37

@andybalaam andybalaam left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any changelog update needed?

@andybalaam
andybalaam removed the request for review from richvdh September 2, 2026 12:13
@poljar

poljar commented Sep 2, 2026

Copy link
Copy Markdown
Contributor Author

Any changelog update needed?

Probably, though not sure what to mention. I guess at least a "this was bumped" would be helpful. The patch still needs some work as well.

@zecakeh

zecakeh commented Sep 4, 2026

Copy link
Copy Markdown
Collaborator

Note that Ruma 0.17.0 was just released.

@poljar

poljar commented Sep 4, 2026

Copy link
Copy Markdown
Contributor Author

Thanks, will update the PR.

@poljar
poljar force-pushed the poljar/bump-uniffi branch from 50670a4 to 86342ea Compare September 4, 2026 14:39
@poljar
poljar force-pushed the poljar/bump-uniffi branch from 4d69558 to 513a02f Compare September 7, 2026 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants