feat(notification): add room topic to NotificationItem and NotificationRoomInfo structs #5300
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onRoomInfo structs
jonasrichardrichter
requested review from
andybalaam
and removed request for
a team
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #5300 +/- ##
==========================================
- Coverage 88.73% 88.72% -0.02%
==========================================
Files 330 330
Lines 88770 88771 +1
Branches 88770 88771 +1
==========================================
- Hits 78772 78758 -14
- Misses 6192 6206 +14
- Partials 3806 3807 +1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds a new
room_topicfield to theNotificationItemstruct and exposes it in the FFI layer viaNotificationRoomInfo. By including the room topic directly in notification-related data structures, clients especially those running in constrained environments such as iOS Notification Service Extensions can more easily access and display the room topic in notifications without requiring additional API calls or context.Signed-off-by: Jonas Richard Richter [email protected]