Skip to content

Short retry for intial client methods to prevent long retry cycles #506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 28, 2022
Merged

Short retry for intial client methods to prevent long retry cycles #506

merged 2 commits into from
Feb 28, 2022

Conversation

manuel2258
Copy link
Contributor

This PR fixes the issue #483

Only open points from my side:

  • Is there anywhere I should document the new behavior?
  • are the tests enough, or should there be one for each changed method?

@manuel2258
Implemented short_retry for intial methods
01e0808 
Implemented RequestConfig::short_retry()
Changed few client methods to use it
Adjusted and added tests for it
@manuel2258
Changed register to really use short_retry()
6bf7b21
poljar
poljar approved these changes Feb 28, 2022
View reviewed changes
Copy link
Contributor

@poljar poljar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't have a changelog yet, I'm planing on changing this soon but it should be auto-generated. So no need to document this further.

The test is enough, thanks.

@poljar
Copy link
Contributor

poljar commented Feb 28, 2022

CI fails because of #508.

@poljar poljar merged commit 7049027 into matrix-org:main Feb 28, 2022
@poljar poljar mentioned this pull request Feb 28, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@poljar poljar poljar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@manuel2258 @poljar