Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: remove some uses of sync_timeline_event! in the base and sdk crates #4565

Merged
merged 4 commits into from
Jan 21, 2025
Merged

test: remove some uses of sync_timeline_event! in the base and sdk crates #4565

merged 4 commits into from
Jan 21, 2025

Conversation

bnjbvr
Copy link
Member

@bnjbvr bnjbvr commented Jan 21, 2025

Part of #3716.

@bnjbvr bnjbvr requested a review from a team as a code owner January 21, 2025 11:25
@bnjbvr bnjbvr requested review from jmartinesp and removed request for a team January 21, 2025 11:25
@bnjbvr bnjbvr changed the title Bnjbvr/remove some sync timeline event test: remove some uses of sync_timeline_event! in the base and sdk crates Jan 21, 2025
jmartinesp
jmartinesp approved these changes Jan 21, 2025
View reviewed changes
Copy link
Contributor

@jmartinesp jmartinesp left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I'd inline some usages of EventFactory, but it's not a big deal. There are others besides the 2 mentioned, but I didn't want to add any extra ones in case we don't want to do it.

crates/matrix-sdk-base/src/client.rs Outdated Show resolved Hide resolved
crates/matrix-sdk-base/src/client.rs Outdated Show resolved Hide resolved
@codecov Codecov
Copy link

codecov bot commented Jan 21, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.39%. Comparing base (210c574) to head (882e7a6).
Report is 4 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #4565      +/-   ##
==========================================
- Coverage   85.40%   85.39%   -0.01%     
==========================================
  Files         285      285              
  Lines       32218    32218              
==========================================
- Hits        27515    27513       -2     
- Misses       4703     4705       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bnjbvr bnjbvr force-pushed the bnjbvr/remove-some-sync-timeline-event branch from 268fb70 to 882e7a6 Compare January 21, 2025 13:59
@bnjbvr bnjbvr enabled auto-merge (rebase) January 21, 2025 13:59
@bnjbvr bnjbvr disabled auto-merge January 21, 2025 13:59
@bnjbvr bnjbvr enabled auto-merge (squash) January 21, 2025 13:59
@bnjbvr bnjbvr merged commit 4341aaf into main Jan 21, 2025
40 checks passed
@bnjbvr bnjbvr deleted the bnjbvr/remove-some-sync-timeline-event branch January 21, 2025 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmartinesp jmartinesp jmartinesp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bnjbvr @jmartinesp