MatrixClient.setAccountData: await remote echo.
#4695
Draft
+282
−41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t3chguy
reviewed
Feb 5, 2025
src/client.ts
Outdated
| // | ||
| // NB that we rely on this operation being synchronous to avoid a race condition: there must be no `await` | ||
| // between here and `this.addListener` below, in case we miss an update. | ||
| if (JSON.stringify(this.store.getAccountData(eventType)) === JSON.stringify(content)) return {}; |
There was a problem hiding this comment.
This isn't guaranteed to work, given the keys aren't being sorted. The key order is based on insertion order for string keys, so will map to JSON-order for JSON-originating content, but for the content provided by the caller that order may not match.
There was a problem hiding this comment.
ugh, true. I guess we need canonical json, or something
richvdh
force-pushed
the
rav/await_accountdata_echo
branch
from
84ca831 to
ac95231
Compare
use fetch-mock rather than whatever this was
richvdh
force-pushed
the
rav/await_accountdata_echo
branch
from
ac95231 to
c0d59bb
Compare
Wait for the echo to come back from the server before we assume the account data has been successfully set
richvdh
force-pushed
the
rav/await_accountdata_echo
branch
from
c0d59bb to
78df5c8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wait for the echo to come back from the server before we assume the account data has been successfully set.
We have a bit of a problem in the dehydration setup code in that it calls
bootstrapSecretStorageand, not unreasonably, expectsisSecretStorageReadyto return true. Currently, it doesn't, becauseisSecretStorageReadychecks the in-memory account data cache, which isn't updated until the echo comes back down/sync.So, the thing to do seems to be to wait for the echo to come back before proceeding. But I'm not really sure where this fits best: I considered putting it in
ServerSideSecretStorageImplor evenbootstrapSecretStorage, but it really feels like this is a wider problem than just secret storage.