Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable key upload to backups where we have the decryption key #4677

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

ajbura
Copy link
Contributor

@ajbura ajbura commented Feb 3, 2025

Fixes #4676

Signed-off-by: Ajay Bura [email protected]

Checklist

  • Tests written for new code (and old code if feasible).
  • New or updated public/exported symbols have accurate TSDoc documentation.
  • Linter and other CI checks pass.
  • Sign-off given on the changes (see CONTRIBUTING.md).

@ajbura ajbura requested a review from a team as a code owner February 3, 2025 07:53
@ajbura ajbura requested review from uhoreg and richvdh February 3, 2025 07:53
@github-actions github-actions bot added the Z-Community-PR Issue is solved by a community member's PR label Feb 3, 2025
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Putting this on hold while we try to understand what bug it is trying to fix, per #4676 (comment).

In any case, we'll need to see an integration test which demonstrates the problem.

@richvdh richvdh changed the title Disable key backup only when both trust via signatures and private key fail Enable key upload to backups where we have the decryption key Feb 3, 2025
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, the fix looks like it makes sense, but the main thing this is missing is a regression test.

Please could you take a look at matrix-js-sdk/spec/integ/crypto/megolm-backup.spec.ts. In there there are some existing tests for checkKeyBackupAndEnable: please could you take a look at them and see if you can add another which covers your usecase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Z-Community-PR Issue is solved by a community member's PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Keys are not uploaded to backup if the backup is not signed
2 participants