Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated parameters and types in CryptoApi #4670

Draft
wants to merge 17 commits into
base: develop
Choose a base branch
from
Draft

Remove deprecated parameters and types in CryptoApi #4670

wants to merge 17 commits into from

Conversation

florianduros
Copy link
Contributor

@florianduros florianduros commented Jan 29, 2025 •
edited
Loading

Remove deprecated parameters in CryptoApi and update rust-crypto .

florianduros and others added 14 commits November 28, 2024 14:14
@florianduros
Remove deprecated calls in webrtc/call.ts
a45de2f
@florianduros
Throw error when legacy call was used
9c4f21b
@florianduros
Merge branch 'develop' into florianduros/rip-out-legacy-crypto/call
020770b
@florianduros
Merge pull request #4562 from matrix-org/florianduros/rip-out-legacy-…
d12fcc4 
…crypto/call

Remove deprecated calls in `webrtc/call.ts`
@florianduros
Remove MatrixClient.initLegacyCrypto (#4620)
1129c45 
* Remove `MatrixClient.initLegacyCrypto`

* Remove `MatrixClient.initLegacyCrypto` in README.md

* Remove tests using `MatrixClient.initLegacyCrypto`
@florianduros
Remove legacy crypto support in sync api (#4622)
8537aee
@florianduros
Remove deprecated DeviceInfo in webrtc/call.ts (#4654)
f763192 
* chore(legacy call): Remove `DeviceInfo` usage

* refactor(legacy call): throw `GroupCallUnknownDeviceError` at the end of `initOpponentCrypto`
@florianduros
Merge branch 'develop' into florianduros/rip-out-legacy-crypto/remove…
ce6f971 
…-legacy-crypto
@florianduros
Remove deprecated methods and attributes of MatrixClient (#4659)
89cec0a 
* feat(legacy crypto)!: remove deprecated methods of `MatrixClient`

* test(legacy crypto): update existing tests to not use legacy crypto

- `Embedded.spec.ts`: casting since `encryptAndSendToDevices` is removed from `MatrixClient`.
- `room.spec.ts`: remove deprecated usage of `MatrixClient.crypto`
- `matrix-client.spec.ts` & `matrix-client-methods.spec.ts`: remove calls of deprecated methods of `MatrixClient`

* test(legacy crypto): remove test files using `MatrixClient` deprecated methods

* test(legacy crypto): update existing integ tests to run successfully

* feat(legacy crypto!): remove `ICreateClientOpts.deviceToImport`.

`ICreateClientOpts.deviceToImport` was used in the legacy cryto. The rust crypto doesn't support to import devices in this way.

* feat(legacy crypto!): remove `{get,set}GlobalErrorOnUnknownDevices`

`globalErrorOnUnknownDevices` is not used in the rust-crypto. The API is marked as unstable, we can remove it.
@florianduros
Remove usage of legacy crypto in event.ts (#4666)
b156707 
* feat(legacy crypto!): remove legacy crypto usage in `event.ts`

* test(legacy crypto): update event.spec.ts to not use legacy crypto types
@florianduros
Remove legacy crypto export in matrix.ts (#4667)
2558903 
* feat(legacy crypto!): remove legacy crypto export in `matrix.ts`

* test(legacy crypto): update `megolm-backup.spec.ts` to import directly `CryptoApi`
@florianduros
Remove usage of legacy crypto in integ tests (#4669)
69db213
@florianduros
feat(crypto api!): remove deprecated methods and types
33afeba
@florianduros
feat(rust-crypto!): remove deprecated optional parameters
1ffa618
@florianduros florianduros mentioned this pull request Jan 29, 2025
Merged
@florianduros florianduros changed the title Remove deprecated parameters in CryptoApi Remove deprecated parameters and types in CryptoApi Jan 29, 2025
@florianduros florianduros force-pushed the florianduros/rip-out-legacy-crypto/clean-up-crypto-api branch from 2693c9c to 644185d Compare January 29, 2025 13:43
@florianduros florianduros marked this pull request as ready for review January 29, 2025 13:53
@florianduros florianduros requested a review from a team as a code owner January 29, 2025 13:53
richvdh
richvdh requested changes Jan 30, 2025
View reviewed changes
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a bit nervous about this: it goes quite a long way beyond "remove legacy crypto", imho. For example findVerificationRequestDMInProgress and storeSessionBackupPrivateKey work ok in rust crypto.

Not saying we shouldn't plan to remove them, but I don't think we should do it as part of this change.

Removing the old DecryptionFailureCodes and CryptoCallbacks seems sensible.

Also, the tests are failing.

@florianduros
Copy link
Contributor Author

The legacy crypto tests are failing because of #4659.

If we plan to remove them, should be in the same release than the removal of the legacy crypto in order to avoir too many releases with breaking changes. Or do we want to do in some weeks/month?

@richvdh
Copy link
Member

richvdh commented Jan 30, 2025

If we plan to remove them, should be in the same release than the removal of the legacy crypto in order to avoir too many releases with breaking changes. Or do we want to do in some weeks/month?

I'm not really sure yet. Right now, I'm mostly nervous that we're making sweeping changes without effective CI.

To be honest, I think we should leave it for a release or two; maybe get a working vNext system going first so that we can do major-version housekeeping regularly without it being a massive headache.

Either way: not part of this PR, please?

@florianduros
Copy link
Contributor Author

I move it back to draft, we will resuscitate it if we need it later

@florianduros florianduros marked this pull request as draft January 30, 2025 15:59
Base automatically changed from florianduros/rip-out-legacy-crypto/remove-legacy-crypto to develop February 7, 2025 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richvdh richvdh richvdh requested changes

@uhoreg uhoreg Awaiting requested review from uhoreg uhoreg is a code owner automatically assigned from matrix-org/element-crypto-web-reviewers

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
X-Breaking-Change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@florianduros @richvdh