Skip to content

feat: add CreatorInCreateEvent to help with default room v11 #465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kegsay merged 3 commits into from
May 6, 2026
Merged

feat: add CreatorInCreateEvent to help with default room v11 #465

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
52795b0
feat: add CreatorInCreateEvent to help with default room v11
FrenchGithubUser Apr 17, 2026
529d3f0
feat: add strictEventByteLimits to help with default room v11
FrenchGithubUser Apr 20, 2026
3661833
chore: better document CreatorInCreateEvent
FrenchGithubUser Apr 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 32 additions & 0 deletions eventversion.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,10 @@ type IRoomVersion interface {
DomainlessRoomIDs() bool
PrivilegedCreators() bool
StateDAGs() bool
CreatorInCreateEvent() bool
Comment thread
FrenchGithubUser marked this conversation as resolved.
// StrictEventByteLimits returns true if this room version enforces field
// length limits in bytes rather than Unicode codepoints (introduced in v11 for synapse).
StrictEventByteLimits() bool
}

type KnownRoomVersionFunc func(RoomVersion) bool
Expand Down Expand Up @@ -110,6 +114,7 @@ var roomVersionMeta = map[RoomVersion]IRoomVersion{
checkKnockingAllowedFunc: disallowKnocking,
checkRestrictedJoinAllowedFunc: disallowRestrictedJoins,
checkCreateEvent: checkCreateEventV1,
creatorInCreateEvent: true,
Copy link
Copy Markdown
Contributor

@reivilibre reivilibre Apr 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think most of these should be false, if I understand it right?

Copy link
Copy Markdown
Contributor Author

@FrenchGithubUser FrenchGithubUser Apr 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is false from room v11 and above

newEventFromUntrustedJSONFunc: newEventFromUntrustedJSONV1,
newEventFromTrustedJSONFunc: newEventFromTrustedJSONV1,
newEventFromTrustedJSONWithEventIDFunc: newEventFromTrustedJSONWithEventIDV1,
Expand All @@ -130,6 +135,7 @@ var roomVersionMeta = map[RoomVersion]IRoomVersion{
checkKnockingAllowedFunc: disallowKnocking,
checkRestrictedJoinAllowedFunc: disallowRestrictedJoins,
checkCreateEvent: checkCreateEventV1,
creatorInCreateEvent: true,
newEventFromUntrustedJSONFunc: newEventFromUntrustedJSONV1,
newEventFromTrustedJSONFunc: newEventFromTrustedJSONV1,
newEventFromTrustedJSONWithEventIDFunc: newEventFromTrustedJSONWithEventIDV1,
Expand All @@ -150,6 +156,7 @@ var roomVersionMeta = map[RoomVersion]IRoomVersion{
checkKnockingAllowedFunc: disallowKnocking,
checkRestrictedJoinAllowedFunc: disallowRestrictedJoins,
checkCreateEvent: checkCreateEventV1,
creatorInCreateEvent: true,
newEventFromUntrustedJSONFunc: newEventFromUntrustedJSONV2,
newEventFromTrustedJSONFunc: newEventFromTrustedJSONV2,
newEventFromTrustedJSONWithEventIDFunc: newEventFromTrustedJSONWithEventIDV2,
Expand All @@ -170,6 +177,7 @@ var roomVersionMeta = map[RoomVersion]IRoomVersion{
checkKnockingAllowedFunc: disallowKnocking,
checkRestrictedJoinAllowedFunc: disallowRestrictedJoins,
checkCreateEvent: checkCreateEventV1,
creatorInCreateEvent: true,
newEventFromUntrustedJSONFunc: newEventFromUntrustedJSONV2,
newEventFromTrustedJSONFunc: newEventFromTrustedJSONV2,
newEventFromTrustedJSONWithEventIDFunc: newEventFromTrustedJSONWithEventIDV2,
Expand All @@ -190,6 +198,7 @@ var roomVersionMeta = map[RoomVersion]IRoomVersion{
checkKnockingAllowedFunc: disallowKnocking,
checkRestrictedJoinAllowedFunc: disallowRestrictedJoins,
checkCreateEvent: checkCreateEventV1,
creatorInCreateEvent: true,
newEventFromUntrustedJSONFunc: newEventFromUntrustedJSONV2,
newEventFromTrustedJSONFunc: newEventFromTrustedJSONV2,
newEventFromTrustedJSONWithEventIDFunc: newEventFromTrustedJSONWithEventIDV2,
Expand All @@ -210,6 +219,7 @@ var roomVersionMeta = map[RoomVersion]IRoomVersion{
checkKnockingAllowedFunc: disallowKnocking,
checkRestrictedJoinAllowedFunc: disallowRestrictedJoins,
checkCreateEvent: checkCreateEventV1,
creatorInCreateEvent: true,
newEventFromUntrustedJSONFunc: newEventFromUntrustedJSONV2,
newEventFromTrustedJSONFunc: newEventFromTrustedJSONV2,
newEventFromTrustedJSONWithEventIDFunc: newEventFromTrustedJSONWithEventIDV2,
Expand All @@ -230,6 +240,7 @@ var roomVersionMeta = map[RoomVersion]IRoomVersion{
checkKnockingAllowedFunc: checkKnocking,
checkRestrictedJoinAllowedFunc: disallowRestrictedJoins,
checkCreateEvent: checkCreateEventV1,
creatorInCreateEvent: true,
newEventFromUntrustedJSONFunc: newEventFromUntrustedJSONV2,
newEventFromTrustedJSONFunc: newEventFromTrustedJSONV2,
newEventFromTrustedJSONWithEventIDFunc: newEventFromTrustedJSONWithEventIDV2,
Expand All @@ -250,6 +261,7 @@ var roomVersionMeta = map[RoomVersion]IRoomVersion{
checkKnockingAllowedFunc: checkKnocking,
checkRestrictedJoinAllowedFunc: allowRestrictedJoins,
checkCreateEvent: checkCreateEventV1,
creatorInCreateEvent: true,
newEventFromUntrustedJSONFunc: newEventFromUntrustedJSONV2,
newEventFromTrustedJSONFunc: newEventFromTrustedJSONV2,
newEventFromTrustedJSONWithEventIDFunc: newEventFromTrustedJSONWithEventIDV2,
Expand All @@ -270,6 +282,7 @@ var roomVersionMeta = map[RoomVersion]IRoomVersion{
checkKnockingAllowedFunc: checkKnocking,
checkRestrictedJoinAllowedFunc: allowRestrictedJoins,
checkCreateEvent: checkCreateEventV1,
creatorInCreateEvent: true,
newEventFromUntrustedJSONFunc: newEventFromUntrustedJSONV2,
newEventFromTrustedJSONFunc: newEventFromTrustedJSONV2,
newEventFromTrustedJSONWithEventIDFunc: newEventFromTrustedJSONWithEventIDV2,
Expand All @@ -290,6 +303,7 @@ var roomVersionMeta = map[RoomVersion]IRoomVersion{
checkKnockingAllowedFunc: checkKnocking,
checkRestrictedJoinAllowedFunc: allowRestrictedJoins,
checkCreateEvent: checkCreateEventV1,
creatorInCreateEvent: true,
newEventFromUntrustedJSONFunc: newEventFromUntrustedJSONV2,
newEventFromTrustedJSONFunc: newEventFromTrustedJSONV2,
newEventFromTrustedJSONWithEventIDFunc: newEventFromTrustedJSONWithEventIDV2,
Expand All @@ -310,6 +324,7 @@ var roomVersionMeta = map[RoomVersion]IRoomVersion{
checkKnockingAllowedFunc: checkKnocking,
checkRestrictedJoinAllowedFunc: allowRestrictedJoins,
checkCreateEvent: checkCreateEventV2,
strictEventByteLimits: true,
newEventFromUntrustedJSONFunc: newEventFromUntrustedJSONV2,
newEventFromTrustedJSONFunc: newEventFromTrustedJSONV2,
newEventFromTrustedJSONWithEventIDFunc: newEventFromTrustedJSONWithEventIDV2,
Expand All @@ -330,6 +345,7 @@ var roomVersionMeta = map[RoomVersion]IRoomVersion{
checkKnockingAllowedFunc: checkKnocking,
checkRestrictedJoinAllowedFunc: allowRestrictedJoins,
checkCreateEvent: checkCreateEventV3,
strictEventByteLimits: true,
// v3 versions relax the room ID check as the room ID has no domain now.
newEventFromUntrustedJSONFunc: newEventFromUntrustedJSONV3,
newEventFromTrustedJSONFunc: newEventFromTrustedJSONV3,
Expand All @@ -353,6 +369,7 @@ var roomVersionMeta = map[RoomVersion]IRoomVersion{
checkKnockingAllowedFunc: checkKnocking,
checkRestrictedJoinAllowedFunc: allowRestrictedJoins,
checkCreateEvent: checkCreateEventV1,
creatorInCreateEvent: true,
newEventFromUntrustedJSONFunc: newEventFromUntrustedJSONV2,
newEventFromTrustedJSONFunc: newEventFromTrustedJSONV2,
newEventFromTrustedJSONWithEventIDFunc: newEventFromTrustedJSONWithEventIDV2,
Expand All @@ -373,6 +390,7 @@ var roomVersionMeta = map[RoomVersion]IRoomVersion{
checkKnockingAllowedFunc: checkKnocking,
checkRestrictedJoinAllowedFunc: disallowRestrictedJoins,
checkCreateEvent: checkCreateEventV1,
creatorInCreateEvent: true,
newEventFromUntrustedJSONFunc: newEventFromUntrustedJSONV2,
newEventFromTrustedJSONFunc: newEventFromTrustedJSONV2,
newEventFromTrustedJSONWithEventIDFunc: newEventFromTrustedJSONWithEventIDV2,
Expand All @@ -392,6 +410,7 @@ var roomVersionMeta = map[RoomVersion]IRoomVersion{
parsePowerLevelsFunc: parsePowerLevels,
checkKnockingAllowedFunc: checkKnocking,
checkCreateEvent: checkCreateEventV1,
creatorInCreateEvent: true,
newEventFromUntrustedJSONFunc: newEventFromUntrustedJSONV2,
newEventFromTrustedJSONFunc: newEventFromTrustedJSONV2,
newEventFromTrustedJSONWithEventIDFunc: newEventFromTrustedJSONWithEventIDV2,
Expand Down Expand Up @@ -436,6 +455,7 @@ var roomVersionMeta = map[RoomVersion]IRoomVersion{
checkKnockingAllowedFunc: checkKnocking,
checkRestrictedJoinAllowedFunc: allowRestrictedJoins,
checkCreateEvent: checkCreateEventV3,
strictEventByteLimits: true,
// v3 versions relax the room ID check as the room ID has no domain now.
newEventFromUntrustedJSONFunc: newEventFromUntrustedJSONV3,
newEventFromTrustedJSONFunc: newEventFromTrustedJSONV3,
Expand Down Expand Up @@ -529,6 +549,10 @@ type RoomVersionImpl struct {
domainlessRoomID bool
// creators have infinite PL
privilegedCreators bool
Comment thread
FrenchGithubUser marked this conversation as resolved.
// creator field is present in the create event content
creatorInCreateEvent bool
// field length limits are in bytes rather than Unicode codepoints
strictEventByteLimits bool
// Events form two graphs, a state DAG and an event DAG.
stateDAGs bool
checkRestrictedJoin func(ctx context.Context, localServerName spec.ServerName, roomQuerier RestrictedRoomJoinQuerier, roomID spec.RoomID, senderID spec.SenderID, privilegedCreators bool) (string, error)
Expand Down Expand Up @@ -562,6 +586,14 @@ func (v RoomVersionImpl) PrivilegedCreators() bool {
return v.privilegedCreators
}

func (v RoomVersionImpl) CreatorInCreateEvent() bool {
return v.creatorInCreateEvent
}

func (v RoomVersionImpl) StrictEventByteLimits() bool {
return v.strictEventByteLimits
}

// StateResAlgorithm returns the state resolution for the given room version.
func (v RoomVersionImpl) StateResAlgorithm() StateResAlgorithm {
return v.stateResAlgorithm
Expand Down
Loading