Skip to content

Conversation

snake14
Copy link
Contributor

@snake14 snake14 commented Oct 10, 2025

Description:

This accompanies a PR for the ActivityLog plugin to add a new activity for when the EntityDuplicator is used and something is successfully copied.

Jira ticket: PG-4455

Review

Copy link
Member

@sgiehl sgiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@snake14 If you need an event to be triggered when something is copied, please simply use Piwik::postEvent, as it's done for other activities as well, and handle everything else in the plugin. We won't add any direct dependencies for any non-core plugins, as this would make things unmaintainable over time.

@snake14
Copy link
Contributor Author

snake14 commented Oct 10, 2025

@snake14 If you need an event to be triggered when something is copied, please simply use Piwik::postEvent, as it's done for other activities as well, and handle everything else in the plugin. We won't add any direct dependencies for any non-core plugins, as this would make things unmaintainable over time.

@sgiehl It's using Piwik::postEvent inside of the method, but I can try to decouple it. I was trying to use something like a DTO instead of arrays to enforce the expected structure to try and avoid the issues like the one we ran into with the privacy changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants