-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Capture new metrics for AI Agent requests #23617
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
e0941e2 to
a40b974
Compare
sgiehl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code overall looks clean and straight forward. No real issues found.
However, I've left a couple of questions that we should clarify before merging.
1addffe to
769f648
Compare
michalkleiner
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was just having a look through the code to see how things are done, and left a few minor comments along the way, hope that's ok :)
0e19337 to
9c636ad
Compare
6488334 to
21c365b
Compare
sgiehl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems some new related tests are failing for PHP 8, those might need some investigation. Otherwise everything looks fine
|
Forced a specific date setup in that test. With "now = 12:00" and tracking data being created from 06:00 on. Worked at least the last CI run, but then again it did not fail for most runs before 🙈 |
Description:
The new "Agent Mode" provided by ChatGPT/NovaAct is using a real browser instance to perform tasks on behalf of the user.
At the moment these visits are tracked just like any other browser, and there is no way to detect them and generate metrics/reports for those agents.
A new
AIAgentsplugin will flag NovaAct and ChatGPT requests, and prepares flagging other agents once we know how to detect them. The plugin uses two new dependent segments ("ai agent" and "human") to provideVisitSummarymetrics.Review