-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Extend anonymisation settings to allow them to be site specific #23443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I don't think the TagManagerTeaser UI test failure is related to changes here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The CNIL stuff looks pretty good, but I think there is a little too much introduced complexity into the settings classes, they are meant to only retrieve db data and compare to policy, so I wouldn't worry about handling backup global values from inside the settings classes.
This reverts commit 473b0f6.
…rovided in some more complex way
Reviewed and discussed with @michalkleiner, I am happy with the CNIL-related changes. |
# Conflicts: # plugins/TagManager
changes applied and final review done by Marc
Description:
Reuse the anonymisation vue component from global settings within site settings to configure anonymisation options per site.
Review