Skip to content

Conversation

michalkleiner
Copy link
Contributor

@michalkleiner michalkleiner commented Jul 21, 2025

Description:

Reuse the anonymisation vue component from global settings within site settings to configure anonymisation options per site.

Review

@michalkleiner michalkleiner requested a review from sgiehl October 2, 2025 04:22
@michalkleiner
Copy link
Contributor Author

I don't think the TagManagerTeaser UI test failure is related to changes here.

Copy link
Contributor

@nathangavin nathangavin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CNIL stuff looks pretty good, but I think there is a little too much introduced complexity into the settings classes, they are meant to only retrieve db data and compare to policy, so I wouldn't worry about handling backup global values from inside the settings classes.

@nathangavin
Copy link
Contributor

The CNIL stuff looks pretty good, but I think there is a little too much introduced complexity into the settings classes, they are meant to only retrieve db data and compare to policy, so I wouldn't worry about handling backup global values from inside the settings classes.

Reviewed and discussed with @michalkleiner, I am happy with the CNIL-related changes.

@michalkleiner michalkleiner requested a review from a team October 3, 2025 02:59
# Conflicts:
#	plugins/TagManager
@michalkleiner michalkleiner requested a review from mneudert October 7, 2025 22:17
@michalkleiner michalkleiner dismissed stale reviews from nathangavin and sgiehl October 8, 2025 21:20

changes applied and final review done by Marc

@michalkleiner michalkleiner merged commit 0c0eb44 into 5.x-dev Oct 8, 2025
47 of 49 checks passed
@michalkleiner michalkleiner deleted the dev-19315 branch October 8, 2025 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c: Privacy For issues that impact or improve the privacy. Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc.

Development

Successfully merging this pull request may close these issues.

6 participants