Skip to content

Code changes #8104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 33 commits into
base: master
Choose a base branch
from
Open

Code changes #8104

wants to merge 33 commits into from

Conversation

@Simbiat
Copy link

@Simbiat Simbiat commented Sep 21, 2025

Description:

Split from #8096 this covers changes to PHP code

Review

Dmitrii Kustov added 30 commits September 21, 2025 19:27
Suspicious type mismatch fix
e185f7d
Inline returns
9858a3d
Use in_array
0e2eea8
Non-optimal if conditions
b405baf
Redundant return
42203f8
Use const syntax
1e2871d
Unnecessary curly braces
0c9c0d7
Throw tags, corrections to types, hint for restoreUserAgentFromClient…
8e7de4d 
…Hints
Null check can be used and faster
8355cd6
Don't change type of argument, strict search
eb69002
Binary safe fopen
72f736d
Type strict in_array and array_search
fcc47c0
(bool) instead of !!
f3eb6c3
Static method invocation
b4572e1
Unnecessary boolean expression
4608b88
Unnecessary type casting
52373e0
Merge unset
dab1633
One-time use variables
6e690d8
PHP_SAPI instead php_sapi_name()
def9e79
Null coalescence
04c6750
Adjust assertions used
5377a10
array_push instead array_merge
4f71e9e
Unset fixture after loop
ac21328
array_key_exists instead in_array
e22497e
Non-optimal regex
586cd9d
count() in a loop
856e7d9
Fixes for PHPCS errors
8df85ee
Fixes for PHPStan errors
7f632c2
Fixes for PHPCS errors
8591617
Ensure string brand
86f987a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Simbiat @sanchezzzhak