-
Notifications
You must be signed in to change notification settings - Fork 503
Add a bunch of feed readers #8065
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
These are some of the feed readers I identified as accessing my blog's RSS feed and that were missing from the device detector.
Seems this Python library has been renamed from UniversalFeedParser to just feedparser.
|
Okay, I moved the libraries and adjusted the names as suggested. TBH I am not sure it makes sense to classify feed-reading libraries as "libraries" from an analytics point of view. They are not general HTTP libs but are made to read feeds. So whatever they are used for is a feed reader and thus the logged request was made by a feed reader. |
|
Well, I am not a maintainer (I just go through new additions finding icons and suggest changes), so maybe you rushed a little bit 😅 But my logic is simple: if a piece of code can be used by multiple separate applications - that's a library. If some browser (for example) is using such piece of code without updating user-agent, you will end up treating the browser as a feed reader, which is not correct. On the other hand, I am not sure if it would matter for statistics if you split them by "pim", "browser", "feed reader" and whatever else in the first place. And if it does, we probably would want to split "mobile app" type into a lot of "subtypes" |
|
Okay. Happy to move things around again, if a maintainer chimes in. |
These are some of the feed readers I identified as accessing my blog's RSS feed and that were missing from the device detector.
Review