Skip to content

Conversation

@dpvc
Copy link
Member

@dpvc dpvc commented Oct 23, 2025

This PR fixes a problem in mhchem where the replacement of arrow macros with mhchem-spoecific ones (in order to use the mhchem font extension) is overly aggressive and replaces some macros for there there is no mhchem equivalent. The change makes the replace() call check that an mhchem version exists before replacing the arrow macro.

Resolves issue mathjax/MathJax#3452.

@dpvc dpvc requested a review from zorkow October 23, 2025 11:14
@dpvc dpvc added this to the v4.0.1 milestone Oct 23, 2025
@codecov
Copy link

codecov bot commented Oct 23, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.66%. Comparing base (27c47f3) to head (dec9d2a).

Additional details and impacted files
@@            Coverage Diff             @@
##           develop    #1372     +/-   ##
==========================================
  Coverage    86.66%   86.66%             
==========================================
  Files          338      338             
  Lines        84384    84396     +12     
  Branches      4779     3152   -1627     
==========================================
+ Hits         73131    73143     +12     
  Misses       11253    11253             

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant