Clear forced inline breaks when switching between renderers, when needed#1293
Merged
Clear forced inline breaks when switching between renderers, when needed#1293
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1293 +/- ##
===========================================
- Coverage 86.71% 86.71% -0.01%
===========================================
Files 337 337
Lines 83979 83988 +9
Branches 4750 3124 -1626
===========================================
Hits 72826 72826
- Misses 11130 11162 +32
+ Partials 23 0 -23 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a page has SVG rendering on by default when loaded, and inline breaks are enabled, then when we switch to CHTML output, all the inline breaks are forced to occur. The is due to the way the SVG output has to be broken into separate SVG nodes, so it had marked the nodes for forced breaks, and those marks aren't removed.
This refactors the old code to unmark the breaks if they were set before and we don't want breaks (i.e., the inline breaks menu setting has changed) or the force-break setting is changing (i.e., the render changed). Then we check if breaks are needed and make them again with the new settings. The unsetting and breaking are no longer one-or-the-other, and only the needed actions are taken.