Update packages and add github actions for tests by zorkow · Pull Request #1271 · mathjax/MathJax-src

zorkow · 2025-06-05T13:09:10Z

PR primarily updates all packages and adds a github action to automatically run tests for PRs into develop branch or when pushing directly to develop. For all this it does quite a bit of housekeeping:

Changes in Main Code

Updates packages to the latest version package.json, pnpm-lock.yaml
fixes some types for the latest typescript compiler
- add type coercion in MathtoolsTags.ts
- explicitly ignores the u flag, which needs target >ES6 in HtmlMethods.ts and UnicodeConfiguration.ts
- ensures promise type in Menu.ts (we could do this by coercing with as unknown as Promise<void> if you don't like the empty then.

Changes in Test Code

Updates packages to the latest version package.json, pnpm-lock.yaml
Moves jest configuration to a .mjs file as .ts now yields errors with latest typescript compiler
Update to tsconfig.js to include DOM library and update path for latest ts-jest version
Update type in setupTex.ts and include sources directly (as per our meeting).

Update to tests

Bussproofs similar to Update bussproof tests, and remove -- from package script #1270
Corrects spelling for imports in Setoptions, Tagformat, Texhtml as they throw errors in Linux. We could adapt the file names of the test to the same spelling. What do you think?

Github Actions

Adds the test action in the .github/workflows. There were still a couple of things missing after our meeting, e.g., I had forgotten to compile the test helpers, the mjs files etc. I've ironed this all out now. As you can see tests are passing for this PR.
I added badges for tests and coverage to the README.

zorkow · 2025-06-05T17:13:31Z

For the code coverage badge, we might have to reactivate code coverage at https://app.codecov.io/gh/mathjax/ using the admin account.

dpvc

This all looks good. Thanks for doing it.

I am working on making the fonts use the scoped package, so that should make the temporary link for mathjax-full be unnecessary. I should have that shortly.

Also note that the current version of mathjax-newcm is 0.4.2-beta.8, but the package.json currently uses 0.4.0-beta.8. I don't think that will make any difference, but thought I should mention it anyway.

dpvc · 2025-06-05T17:27:49Z

.github/workflows/test.js.yml

+          pnpm mjs:compile
+          components/bin/makeAll --mjs --terse --build components/mjs
+          pnpm cjs:compile
+          pnpm cjs:components:src:build
+          components/bin/makeAll --cjs --terse --build components/cjs
+          pnpm copy:pkg cjs


Would you be willing to use pnpm -s rather than just pnpm for these (and the ones below)? That way, you only see that script output rather than the pnpm commands themselves. I think that looks cleaner.

dpvc · 2025-06-05T17:30:01Z

testsuite/jest.config.mjs

 */

-import type {Config} from 'jest';
+// import type {Config} from 'jest';


Remove this rather than comment out?

Thanks. I meant to do that and forgot.

dpvc · 2025-06-05T17:43:41Z

We could adapt the file names of the test to the same spelling

What do you think is best? I don't have strong feelings either way.

dpvc · 2025-06-05T19:18:24Z

I've made the v0.4.3-beta.8 releases of the fonts, so you might try switching to that and removing the mathjax-full link and see if that works now.

codecov · 2025-06-05T19:51:11Z

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

zorkow · 2025-06-05T20:02:04Z

@dpvc I'll take care of your comments in a little while.
In the meantime: Here is our first successfully uploaded coverage test:
https://app.codecov.io/gh/mathjax/mathjax-src/tree/update%2Fpackages

zorkow · 2025-06-05T20:17:01Z

We could adapt the file names of the test to the same spelling

What do you think is best? I don't have strong feelings either way.

I think it's good to be consistent. I will rename the files.

zorkow · 2025-06-05T20:55:22Z

I've made the v0.4.3-beta.8 releases of the fonts, so you might try switching to that and removing the mathjax-full link and see if that works now.

I note that changing the font gets us back to the old values in Bussproofs.test.ts (e.g., 9.111em instead of 9.11em). Is that to be expected?

zorkow · 2025-06-05T21:28:11Z

For the record:
Two more changes in tests node.test.ts and esm.test.ts that contained the mathjax-full path. That was hidden due to setting the link.

dpvc · 2025-06-05T23:12:54Z

Here is our first successfully uploaded coverage test:

That's pretty cool. Thanks for working that out.

I note that changing the font gets us back to the old values in Bussproofs.test.ts ... Is that to be expected?

Probably. I have been linking to the latest fonts, so the new values were probably in effect when I was writing all the TeX tests some months ago. I probably updated those tests at that time. But doing a pnpm install changed that back at some point, and that gave us the old values. You would be getting the same. Now that the 0.4.3-beta.8 fonts are available, they have the new values. I think I vaguely remember adjusting some spacing values, but don't remember the specifics.

Two more changes in tests node.test.ts and esm.test.ts that contained the mathjax-full path.

I was preparing a PR for that myself. The same change needs to be made in system.test.ts as well, though. (You didn't notice it because loading from a module fails in system.js, and so the failure was what was expected.

dpvc · 2025-06-05T23:38:04Z

After this update, pnpm -s lint no longer runs. The eslint.config.mjs file imports from @eslint/js, but there is no longer an node_modules/@eslint directory if I remove node_modules and do a fresh pnpm install. If I change @eslint/js to eslint, then I get an error about the eslint.config.recommended (grepping for recommended in all the node_modules/eslint* directory finds nothing). Commenting out that configuration allows the linting to run, but I get warnings:

/Users/dpvc/Desktop/Folders/Tumlook/Data/Code/JavaScript/MathJax/Code/Git/mathjax/MathJax-src/ts/core/MmlTree/MmlNodes/mo.ts
  144:3  warning  Unused eslint-disable directive (no problems were reported from 'no-misleading-character-class')

/Users/dpvc/Desktop/Folders/Tumlook/Data/Code/JavaScript/MathJax/Code/Git/mathjax/MathJax-src/ts/input/tex/html/HtmlMethods.ts
  46:49  warning  Unused eslint-disable directive (no problems were reported from 'no-control-regex')

/Users/dpvc/Desktop/Folders/Tumlook/Data/Code/JavaScript/MathJax/Code/Git/mathjax/MathJax-src/ts/input/tex/mathtools/MathtoolsMappings.ts
  165:3  warning  Unused eslint-disable directive (no problems were reported from 'no-sparse-arrays')

/Users/dpvc/Desktop/Folders/Tumlook/Data/Code/JavaScript/MathJax/Code/Git/mathjax/MathJax-src/ts/input/tex/unicode/UnicodeConfiguration.ts
  137:7  error  Use "@ts-expect-error" instead of "@ts-ignore", as "@ts-ignore" will do nothing if the following line is error-free  @typescript-eslint/ban-ts-comment
  148:7  error  Use "@ts-expect-error" instead of "@ts-ignore", as "@ts-ignore" will do nothing if the following line is error-free  @typescript-eslint/ban-ts-comment

/Users/dpvc/Desktop/Folders/Tumlook/Data/Code/JavaScript/MathJax/Code/Git/mathjax/MathJax-src/ts/output/common/FontData.ts
  472:3  warning  Unused eslint-disable directive (no problems were reported from 'no-sparse-arrays')

✖ 6 problems (2 errors, 4 warnings)
  0 errors and 4 warnings potentially fixable with the `--fix` option.

zorkow · 2025-06-06T14:51:36Z

After this update, pnpm -s lint no longer runs. The eslint.config.mjs file imports from @eslint/js, but there is no longer an node_modules/@eslint directory if I remove node_modules and do a fresh pnpm install. If I change @eslint/js to eslint, then I get an error about the eslint.config.recommended (grepping for recommended in all the node_modules/eslint* directory finds nothing). Commenting out that configuration allows the linting to run, but I get warnings:

There's always something... I did not try linting, I thought that was running automatically via husky.
What's odd is that updating the packages seems to have changed the eslint package source.
I'll have a look.

zorkow added 10 commits June 3, 2025 11:56

Upgrade packages

fe88f40

adapt types for latest tsc

7fe4e40

add ts-ignore for regexp flags u which is not in target ES5

c350a09

fixes filenams in tests and some measures in bussproof tests

226456e

update test config for latest typescript and gh actions use

685b5c0

corrects types and adds missing dom lib for tsc

aa7f8f2

update package.json for latest pnpm

af9691d

adds the github test actions

a3f1f46

ensure to allow js as import in test helpers

2f98b99

avoid declaration file error explicitly

5819fdb

zorkow changed the title ~~Update/packages~~ Update packages and add github actions for tests Jun 5, 2025

zorkow added 3 commits June 5, 2025 18:41

update packages for tests

a963ab1

add coverage and test report badges

9af730b

corrects badge paths

7ac6d95

zorkow requested a review from dpvc June 5, 2025 17:09

zorkow marked this pull request as ready for review June 5, 2025 17:09

zorkow mentioned this pull request Jun 5, 2025

Update bussproof tests, and remove -- from package script #1270

Closed

dpvc approved these changes Jun 5, 2025

View reviewed changes

add upload token for code coverage report

13dfafc

incorporate review comments

f27bde3

zorkow added 2 commits June 5, 2025 23:05

update font, remove link, ensure ts-jest gets right tsconfig

6e40080

undo bussproofs test changes

ac62404

zorkow merged commit 4775492 into develop Jun 5, 2025
3 checks passed

zorkow deleted the update/packages branch June 5, 2025 21:28

zorkow mentioned this pull request Jun 6, 2025

Fixes problems with eslint #1273

Merged

dpvc added this to the v4.0 milestone Jun 17, 2025

Conversation

zorkow commented Jun 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes in Main Code

Changes in Test Code

Update to tests

Github Actions

Uh oh!

zorkow commented Jun 5, 2025

Uh oh!

dpvc left a comment

Choose a reason for hiding this comment

Uh oh!

dpvc Jun 5, 2025

Choose a reason for hiding this comment

Uh oh!

zorkow Jun 5, 2025

Choose a reason for hiding this comment

Uh oh!

dpvc Jun 5, 2025

Choose a reason for hiding this comment

Uh oh!

zorkow Jun 5, 2025

Choose a reason for hiding this comment

Uh oh!

dpvc commented Jun 5, 2025

Uh oh!

dpvc commented Jun 5, 2025

Uh oh!

codecov bot commented Jun 5, 2025

Welcome to Codecov 🎉

Uh oh!

zorkow commented Jun 5, 2025

Uh oh!

zorkow commented Jun 5, 2025

Uh oh!

zorkow commented Jun 5, 2025

Uh oh!

zorkow commented Jun 5, 2025

Uh oh!

Uh oh!

dpvc commented Jun 5, 2025

Uh oh!

dpvc commented Jun 5, 2025

Uh oh!

zorkow commented Jun 6, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

zorkow commented Jun 5, 2025 •

edited

Loading