Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

potr pots complete #225

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

potr pots complete #225

wants to merge 4 commits into from
+3,244 −1,453

Conversation

Serhii-Khobotov
Copy link

volodymyr-soltys97
volodymyr-soltys97 suggested changes May 22, 2024
View reviewed changes
Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job 👍
Let's improve your page

  1. Add hover effects for all clickable elements on the page
image
  1. Fix color for these links, check it on the design
image
  1. The menu should be on the right side of the browser window. Check it on the design
image

TarasHoliuk
TarasHoliuk suggested changes May 22, 2024
View reviewed changes
Copy link

@TarasHoliuk TarasHoliuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! Unfortunately, I cannot do a review because of problems with the deployed landing page:

image

Please, re-deploy your solution, make sure it works and re-request review again 🙂

@Serhii-Khobotov
Copy link
Author

https://Serhii-Khobotov.github.io/Potr_Pots/

maxim2310
maxim2310 suggested changes May 23, 2024
View reviewed changes
Copy link

@maxim2310 maxim2310 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job overall! Just couple tiny things needs to be fixed before approval)

  1. check space according design and font family
    image
  2. would be nice to add hover effect on these links
    image

@Serhii-Khobotov Serhii-Khobotov requested a review from maxim2310 May 23, 2024 12:48
anastasiiavorobiova
anastasiiavorobiova approved these changes May 23, 2024
View reviewed changes
Copy link

@anastasiiavorobiova anastasiiavorobiova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anastasiiavorobiova anastasiiavorobiova

@volodymyr-soltys97 volodymyr-soltys97

@TarasHoliuk TarasHoliuk

@maxim2310 maxim2310

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Serhii-Khobotov @volodymyr-soltys97 @TarasHoliuk @maxim2310 @anastasiiavorobiova