Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add task solution #215

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

Copy link

@loralevitska loralevitska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You did an amazing job! Looks good! Let's do some improvements (check comments)

  • this button disappear by hover on it
    image
  • fix 404 error by click on this button
    image
  • all form field should be required
  • fix mobile menu according mockup
    image
    image
  • fix this text and other blocks on mobile mode
    image

Copy link

@DarkMistyRoom DarkMistyRoom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! Let's improve it a bit more:

  • these dynamic windows should open by clicking on "+" and close by "-"
image
  • This section looks a bit shifted to the left. Maybe because the grid has no gaps and the columns have different width
image
  • this background geometrical element should stick to the edges
image
  • add scroll to the menu to make it work fine in landscape mode
image
  • the message field in the form should be required

Copy link

@vadiimvooo vadiimvooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants