Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

completed #214

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

completed #214

wants to merge 9 commits into from

Conversation

Horizon-git
Copy link

DarkMistyRoom
DarkMistyRoom suggested changes Mar 20, 2024
View reviewed changes
Copy link

@DarkMistyRoom DarkMistyRoom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! Here are a few topics for improving:

  • scroll disappears after clicking on the cart icon
image
  • all contacts should be links
image
  • please remove the background on auto-completing
image
  • reset the form on submission
  • these should be links to real socials. And they placed closer to each other on the mockup
image
  • remove horizontal scroll on tab and mobile screen
  • how to close the menu in landscape mode?
image

IvanFesenko
IvanFesenko suggested changes Mar 20, 2024
View reviewed changes
Copy link

@IvanFesenko IvanFesenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Add favIcon
  • Double scroll on tablet/mob resolution
    2024-03-20_15h16_41
  • All fields in form should be required
  • Positioning in % not good idea
    2024-03-20_15h19_49

@Horizon-git Horizon-git requested a review from IvanFesenko March 20, 2024 13:51
IvanFesenko
IvanFesenko suggested changes Mar 20, 2024
View reviewed changes
Copy link

@IvanFesenko IvanFesenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not fixed
2024-03-20_16h06_18
https://github.com/mate-academy/Potr_Pots/assets/61904995/4110abd6-aac1-450a-9c2a-4aa076d4f51d

Viktor-Kost
Viktor-Kost suggested changes Mar 20, 2024
View reviewed changes
Copy link

@Viktor-Kost Viktor-Kost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GJ! Almost done

To improve:

  1. add hover effects to footer links
  2. external links such as social networks and maps should open a new tab
  3. set a current year
Screenshot 2024-03-20 at 19 41 51
  1. add this element at mobile
Screenshot 2024-03-20 at 19 38 53
  1. set a correct font color for these texts
Screenshot 2024-03-20 at 19 37 50 Screenshot 2024-03-20 at 19 39 45 Screenshot 2024-03-20 at 19 43 24

Recommendations:

  1. should be aligned to the right side
Screenshot 2024-03-20 at 19 35 12
  1. at right bottom corner
Screenshot 2024-03-20 at 19 36 23

@Horizon-git Horizon-git requested a review from Viktor-Kost March 20, 2024 20:08
maxim2310
maxim2310 approved these changes Mar 21, 2024
View reviewed changes
Copy link

@maxim2310 maxim2310 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxim2310 maxim2310 maxim2310 approved these changes

@DarkMistyRoom DarkMistyRoom Awaiting requested review from DarkMistyRoom

@IvanFesenko IvanFesenko Awaiting requested review from IvanFesenko

@Viktor-Kost Viktor-Kost Awaiting requested review from Viktor-Kost

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Horizon-git @IvanFesenko @maxim2310 @DarkMistyRoom @Viktor-Kost