-
Notifications
You must be signed in to change notification settings - Fork 347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add task solution #210
base: master
Are you sure you want to change the base?
add task solution #210
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GJ!
To improve:
-
use svg for icons instead of png one
-
too big. check sizes at figma

-
All interactive elements(links, buttons, pictures, icons) should have a hover effect and cursor pointer. User must intuitively understand that he can interact with them.
Add hover effect to images and links -
remove default input outline and autocomplete styles


-
add a correct type for email field to have a basic validation
-
This button should lead to an appropriate section

- Set a corect order for elements.
Figma:

- Decrease left indent

- Check font styles

- Titles like this aren't an image. You should use a correct font

- Add a yellow background

- Set correct elements order and decrease left indent

- Shouldn't be centered




- Set a current year

- Check an indent between elements


- Add this element

- Check hover effect for this section. Since when I hover to this button I see the text from the righter button

- check font styles and indents between elements

- Not like at figma. Order, indents

There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job, a few changes required:
- Fix padding for the sections, check for the appropriate one in mockup
- This part should be fixed as well, please check the mockup
- Scaled element should not overlap the neighbours.
- This block should be fixed as well, please check the mockup
- Please check the mockup, the distance between block is wrong
6 This block is also have wrong distances and elements with wrong sizes, please fix it as well
- Address should be clickable
- The same probles exists on other sizes of screen, so please fix it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done
DEMO LINK