Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow PHP 8.3 and Symfony 7.0 #93

Merged
merged 20 commits into from
Sep 14, 2024
Merged

Allow PHP 8.3 and Symfony 7.0 #93

merged 20 commits into from
Sep 14, 2024

Conversation

turegjorup
Copy link

Allow PHP 8.3 and Symfony 7.0

maschmann and others added 20 commits February 20, 2022 19:59
@maschmann @rkaldung
Prepare v4.0 release (maschmann#76)
6545925 
* add sshPipelining test

* update readme with more development goals

* Feature/php 8 migration (maschmann#68)

* move to php 8 compat only

* fix phpstan config

* fix phpcs issues

* add phpunit and printer

* remove version from composer.json

* add phpunit as dev dependency to keep scrutinizer happy

* Added version 6 for symfony/process to the required versions (maschmann#75)

* fix phpcs, local versions, add 8.1 to travis

* Add new badges, remove travis & Scrutinizer, switch to GH actions

* Add more useful names to actions >.<

* remove travis file

* fix merge oversight

Co-authored-by: Roy Kaldung <[email protected]>
@maschmann
feature/build and version cleanup (maschmann#84)
028a756 
* github workflow update
* move to different phpunit runner
* remove lock file, open dependencies
* ignore lock file, update actions
* move to build matrix
@RoussKS
allow all psr/log versions to be used. methods & interface/traits do …
7f9af0c 
…not change between versions
@maschmann
Merge pull request maschmann#83 from RoussKS/main
8d03a84 
Updates requires versions for psr/log 
thx @RoussKS for researching and contributing!
@RoussKS
removed IDE's Import
9eec90b
@RoussKS
allow JSON Format to be used with the --extra-vars parameter. Escape …
e928338 
…single quotes as required.
@RoussKS
removed escaping because the library already handles this via the sym…
0b4a7a1 
…fony process escaping
@bambamboole
fix error output
724e47b
@bambamboole
Extend tests
96b97ec
@maschmann
Merge pull request maschmann#86 from RoussKS/main
4b0d35a 
Allow JSON Format Ansible --extra-vars
@bambamboole
Merge branch 'main' into mc-fix-error-output
8d74f92
@bambamboole
remove not used use statement
c2cc649
@maschmann
Merge pull request maschmann#87 from bambamboole/mc-fix-error-output
4e96de9 
Fix error output if no callback is provided
@RoussKS
re-added json extra-vars tests & comments that were accidentally remo…
fbc227e 
…ved from PR maschmann#87
@RoussKS
updated docblock
4ced822
@turegjorup
Allow PHP 8.3 and Symfony 7.0
bd494b6
@turegjorup
Update PHP version matrix in actions workflow
9f1b739
@turegjorup
Allow psr/log 2.0 and 3.0
ea07a7a
@maschmann
Merge pull request maschmann#89 from RoussKS/main
1a116c4 
Restore --extra-var JSON string tests
@turegjorup
Merge branch 'main' into develop
2d3c301 
# Conflicts:
#	.github/workflows/static-analysis.yml
#	Asm/Ansible/Command/AnsiblePlaybook.php
#	composer.json
@elpoutro elpoutro mentioned this pull request May 27, 2024
Closed
@matrixes matrixes mentioned this pull request Jul 30, 2024
Open
@maschmann maschmann merged commit 197fda4 into maschmann:develop Sep 14, 2024
@maschmann
Copy link
Owner

maschmann commented Sep 14, 2024 •
edited
Loading

Hi, did you try this with the unit tests on 8.3?
I've set up a docker env with php 8.3-cli and your changes (plus latest phpunit etc.) which caused some strange behavior where symfony process does not work with the provided (fake) ansible-galaxy executables anymore. It's working for php 8.1 and 8.2 (same docker setup, basically). Causes me a lot of headache at the moment, since I cannot find where it's broken. Already cost me two nights of debugging :-D But I also migrated the tests to latest phpunit versions.
8.2 + Process 7.x -> works
8.3 + Process 6/7.x -> broken
The issue seems to be proc_open, since the error is not directly from symfony process.

After some search, I found this php 8.3 issue here.
I'll have to check if the process initialization has to be changed to fix this behavior.

// edit

You can check this in feature/add-docker-dev - I've merged current development and did some rework on the tests, setup etc.

// edit #2

My bad. Using vfs://... as working dir for the process creation in tests breaks with php 8.3's changed behavior of proc_open. Which was a bug in the first place (according to the link from above). Seems it's all working now.
Will create a new release version soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@turegjorup @maschmann @RoussKS @bambamboole