Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make process available via getter #91

Conversation

bambamboole
Copy link
Contributor

Fixes #90 by exposing the process via a stateful getter which gets reset on runProcess

@maschmann
Copy link
Owner

This PR introduces two changes. the return to sprintf'ing the hosts and also an exposed getter for symfony process.
I'd prefer to keep the process hidden within the wrappers and fixing the STDOUT issue from #90 in another way (see comment).
The host sprintf I'd gladly accept :-)

@bambamboole
Copy link
Contributor Author

let me update the PR :)

@bambamboole
Copy link
Contributor Author

AH I think the stuff was in the other PR. let me close this for now. Looking forward to the new release.

@maschmann
Copy link
Owner

You had both changes within this one, I guess (757b226)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When using json() failing command has output on stdout and not stderr
2 participants