Skip to content

add option for custom configs #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 49 commits into
base: master
Choose a base branch
from

Conversation

pablodav
Copy link
Collaborator

No description provided.

Comment on lines +84 to +91
- config_name: some_config # Do not add the .conf, it will be added by the role
# Example lines to add a return to some other url
lines:
- "server {"
- " listen 80;"
- " server_name host.domain.net;"
- " return 301 http://someother:port/path.html;"
- "}"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not use a dict instead of items ?

nginx_custom_conf:
  - default: |
      server {
        listen: 80;
        ...
      }

Task should be:

- name: deploy custom conf files
  template:
    content: {{ item.value }}
    dest: "{{ nginx_reverse_proxy_config_directory }}/{{ item.key }}.conf"
  with_dict: "{{ nginx_custom_conf }}"

@zbbfufu
Copy link

zbbfufu commented Mar 12, 2020

I would like to have this feature too, it would allow us to declare at least a default site with a config like this:

server {
    listen 80 default_server;
    server_name _;
    index index.html;
    root /usr/share/nginx/html;
}

since there is already a bind mount from {{nginx_base_directory}}/default to /usr/share/nginx/html.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants