-
Notifications
You must be signed in to change notification settings - Fork 13
add option for custom configs #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
pablodav
wants to merge
49
commits into
marvinpinto:master
Choose a base branch
from
CoffeeITWorks:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zbbfufu
approved these changes
Mar 12, 2020
Comment on lines
+84
to
+91
- config_name: some_config # Do not add the .conf, it will be added by the role | ||
# Example lines to add a return to some other url | ||
lines: | ||
- "server {" | ||
- " listen 80;" | ||
- " server_name host.domain.net;" | ||
- " return 301 http://someother:port/path.html;" | ||
- "}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not use a dict instead of items ?
nginx_custom_conf:
- default: |
server {
listen: 80;
...
}
Task should be:
- name: deploy custom conf files
template:
content: {{ item.value }}
dest: "{{ nginx_reverse_proxy_config_directory }}/{{ item.key }}.conf"
with_dict: "{{ nginx_custom_conf }}"
I would like to have this feature too, it would allow us to declare at least a default site with a config like this: server {
listen 80 default_server;
server_name _;
index index.html;
root /usr/share/nginx/html;
} since there is already a bind mount from |
Ssl nginx servers
replace deprecated ansible module include with import_tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.