Unicode support for web #25
Conversation
… key doesn't exist.
…n't exist (on Android and iOS platform too).
| @@ -18,7 +18,6 @@ npm-debug.log* | |||
| .sass-cache/ | |||
| .tmp/ | |||
| .versions/ | |||
| dist/ | |||
There was a problem hiding this comment.
hello, why do you want to have dist folder included in git?
There was a problem hiding this comment.
Hi, i included the dist folder only to import easily the modified library from my github repo to my project. I opened the pull request only for the commit https://github.com/lucaboy/capacitor-secure-storage-plugin/commit/a742bb2f17cec1f21ef5a9af2e2e9f7121d5d4f8.
ios/Plugin/Plugin.swift
Outdated
| @@ -26,6 +26,10 @@ public class SecureStoragePlugin: CAPPlugin { | |||
| @objc func get(_ call: CAPPluginCall) { | |||
| let key = call.getString("key") ?? "" | |||
| let hasValue = KeychainWrapper.standard.hasValue(forKey: key) | |||
| call.success([ | |||
| "value": KeychainWrapper.standard.string(forKey: key) ?? "" | |||
There was a problem hiding this comment.
if item with given key does not exist will it return null or empty string?
There was a problem hiding this comment.
It returns empty string, but i just changed it to return null.
|
Hello @lucaboy, is this supose to be real pull request? or are you just making changes to your forked copy? |
|
Not using IMHO, best would be to have a typed https://developer.paypal.com/braintree/docs/reference/general/result-objects/node |
No description provided.