Define NOMINMAX when including Windows.h #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #81 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 57 57
Branches 3 3
=========================================
Hits 57 57 ☔ View full report in Codecov by Sentry. |
martin-olivier
approved these changes
Feb 26, 2024
|
Hello @DolphyWind, Thank you for your pull request. BR |
martin-olivier
added a commit
that referenced
this pull request
Jan 3, 2025
This reverts commit c5b46c6. This is done to be able to merge dev branch into main. The commit will be restored on top of the dev branch. Signed-off-by: Martin Olivier <[email protected]>
martin-olivier
pushed a commit
that referenced
this pull request
Jan 4, 2025
* Define NOMINMAX when including Windows.h * Fix some formatting (cherry picked from commit c5b46c6) Signed-off-by: Martin Olivier <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Hi, really nice library. I've recently got into an issue while using this library with
std::numeric_limits<T>::min()andstd::numeric_limits<T>::max()and it turned out those pesky evilminandmaxmacros fromWindows.hwere the issue. This is a small pr that fixes it.Changes include
Checklist