Keep all upload data persistent and advice on redirections issues #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ServerName helps when the cannonical redirections from Apache use a port the front proxy doesn't listen on - see martialblog#196
All subdirectories are used for persistent storage, keeping e.g. themes, plugins and survey uploads.
|
Hi, thanks for the PR. I'll have a look at it! |
|
Thanks for typo corrections 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the example persistent data config to keep also other directories, like
theme,pluginsetc. in the volume. The wholeuploaddirectory is intended for persistent data and current example config causes e.g. lose of theme modifications on the container upgrade.In addition, the "Known issues" section discusses the topic as well as another issue with the Apache, which tries to use its own port when redirecting to canonical URLs. When put behind another proxy listening on different ports, it produces URLs not accessible by the client.
Close #196