Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move API tests to this repo #1047

Open
wants to merge 43 commits into
base: mainline
Choose a base branch
from
Open

Move API tests to this repo #1047

wants to merge 43 commits into from

Conversation

farshidz
Copy link
Collaborator

@farshidz farshidz commented Nov 21, 2024 •
edited
Loading

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Improvement/refactoring

  • What is the current behavior? (You can also link to an open issue here)
    API tests in another repo

  • What is the new behavior (if this is a feature change)?
    API tests moved to the Marqo repo. We will decommission the API tests repo

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
    No

  • Have unit tests been run against this PR? (Has there also been any additional testing?)

  • Related Python client changes (link commit/PR here)

  • Related documentation changes (link commit/PR here)

  • Other information:

  • Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added / updated (for bug fixes / features)

@farshidz farshidz force-pushed the farshid/restructure-tests branch from ec5ffc8 to 2849cc2 Compare November 21, 2024 03:36
@farshidz farshidz marked this pull request as ready for review December 11, 2024 04:17
@farshidz farshidz closed this Dec 11, 2024
@farshidz farshidz reopened this Dec 11, 2024
@farshidz farshidz changed the title Restructure tests Move API tests to this repo Dec 20, 2024
@papa99do
Copy link
Collaborator

papa99do commented Dec 24, 2024 •
edited
Loading

Hello @farshidz , I noticed you moved all the exisiting unit and integ tests to the integ_tests folder. What is the plan to distinguish integ tests from unit tests going forward?

@farshidz
Copy link
Collaborator Author

Hello @farshidz , I noticed you moved all the exisiting unit and integ tests to the integ_tests folder. What is the plan to distinguish integ tests from unit tests going forward?

Unit tests will be in unit_tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@farshidz @papa99do