-
-
Notifications
You must be signed in to change notification settings - Fork 156
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Compdump was erroneously regenerated on every startup. Fixes #480
- Loading branch information
1 parent
f07efda
commit 866c661
Showing
1 changed file
with
14 additions
and
14 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 comments
on commit 866c661
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In my opinion this would be worth a release because of the speedups. What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gilice Sure. I'll try to make a new release soon, once I'm certain main
is stable and production-ready.
the Compdump bug doesn't seem to have entirely been fixed as it's still getting called during every run with the latest codebase(as of today). The issue seems to on this line . If _comps[-command-] doesn't have a value then all is well. but if it has and in my case it is always _autocd then it removes the $_comp_dumpfile .
so what this comparison is intended to do anyway ? is _comps[-command-] set by _autocomplete.command and we want to make sure that this is the case , or something on that lines ?