partial filename too long fix and resumable rebalances#77
Open
r0b0tb4c0n wants to merge 2 commits intomarkusressel:masterfrom
Open
partial filename too long fix and resumable rebalances#77r0b0tb4c0n wants to merge 2 commits intomarkusressel:masterfrom
r0b0tb4c0n wants to merge 2 commits intomarkusressel:masterfrom
Conversation
|
I like the idea of using a shorter .ZIR instead of .balance! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
as a low-hanging fruit solution for the filename too long error, the filename suffix was changed from .balance to .ZIR -- (Z)fs (I)nplace (R)ebalance. a possible long-term solution would be to use something like
LC_ALL=C tr -cd 'A-Za-z0-9' < /dev/urandom | head -c 32to generate a random name as a uuidenable resumable rebalances by adding a
--resumeflag that does the following:rebalance_db.txtgrouped_inodes.txtand writes the difference toresume_grouped_inodes.txtinode_fileto be eithergrouped_inodes.txtif not resuming orresume_grouped_inodes.txtif resuming for later use in the script