Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The new button design & theme matches with YouTube Button theme. #2

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

xol69
Copy link

@xol69 xol69 commented Apr 29, 2023

Hi,
lets me know your thought about these changes.

one more thing, I noticed two potential bugs when I'm using Youloop.

  1. if i click youloop button when the video is in a pause state, it starts to play. I'm not sure if it's good or not, so kept the function as it is. but if you think it needs to fix then simply deleting line 43 "video.play();" could resolve this.
  2. if I decrease the browser window, of course, the video screen also starts decreasing, and so does youtube video toolbar. at some point there is not enough space for all buttons. at that time Youloop button starts decreasing its size. where it should disappear instead of keep shrinking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant