fix: delete all typed commands when deleteMessages is set #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
i guess this was closed by accident when i renamed feel free to re-open if you want to |
markokajzer
reviewed
Sep 9, 2024
| @@ -44,5 +44,15 @@ export default class MessageHandler { | |||
| } | |||
|
|
|||
| commandToRun.run(message, params); | |||
|
|
|||
| if (deleteMessages && !message.deleted && !this.wasMessageAlreadyDeleted(message)) { | |||
There was a problem hiding this comment.
config is already imported. as an example check L23 which just uses config.prefix.length
i think you can just skip using a parameter, and simply use config.deleteMessages here
There was a problem hiding this comment.
i'd also love for the command to finish first, and then delete the message, so everyone knows what's up 🤙
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #135
Feel free to suggest rework if you don't agree with the approach.