Skip to content

Conversation

@rjrudin
Copy link
Contributor

@rjrudin rjrudin commented Oct 15, 2025

Verifying the tests succeed, but will release from this branch first.

Introduced in 6.0.0 during refactor, due to missing test on the LSQT document being created.
MLE-24511 Fixing bug with updating LSQT properties
Will likely bump to a snapshot build of marklogic-junit5 until that has 2.0 released.
Also bumped Gradle wrapper from 8.14.2 to 8.14.3
This is just to verify the ml-app-deployer tests run fine using marklogic-junit5 2.x. This has no impact on users.
Not bumping "version" yet as that makes Jenkins unhappy when it tries to publish. Getting everything else ready first.
Copilot AI review requested due to automatic review settings October 15, 2025 15:41
@github-actions
Copy link

Copyright Validation Results
Total: 59 | Passed: 6 | Failed: 0 | Skipped: 53 | at: 2025-10-15 15:41:53 UTC | commit: b8cf118

⏭️ Skipped (Excluded) Files

  • .copyrightconfig
  • build.gradle
  • examples/alert-project/build.gradle
  • examples/corb2-project/build.gradle
  • examples/cpf-project/build.gradle
  • examples/custom-forests-and-replicas-project/build.gradle
  • examples/custom-rest-rewriter-project/build.gradle
  • examples/data-services/build.gradle
  • examples/dependency-project/ml-gradle-client-project/build.gradle
  • examples/disconnected-project-using-plugins-and-gradlew/build.gradle
  • examples/disconnected-project/gradle.properties
  • examples/entity-services-project/build.gradle
  • examples/external-security/build.gradle
  • examples/failover-project/build.gradle
  • examples/flexrep-project/build.gradle
  • examples/flexrep-with-path-project/build.gradle
  • examples/ignore-resources-project/build.gradle
  • examples/jdbc-project/build.gradle
  • examples/local-testing-project/gradle.properties
  • examples/marklogic-cloud-project/gradle.properties
  • examples/maven-project/build.gradle
  • examples/mimetypes-project/build.gradle
  • examples/minimal-project/build.gradle
  • examples/mlcp-project/build.gradle
  • examples/no-appservers-project/build.gradle
  • examples/partition-project/gradle.properties
  • examples/properties-project/build.gradle
  • examples/qbv-example/build.gradle
  • examples/redaction-ruleset-project/build.gradle
  • examples/role-project/build.gradle
  • examples/roxy-project/build.gradle
  • examples/sample-project/build.gradle
  • examples/schemas-project/build.gradle
  • examples/ssl-2way-project/build.gradle
  • examples/ssl-project/build.gradle
  • examples/temporal-lsqt-project/build.gradle
  • examples/temporal-project/build.gradle
  • examples/triggers-project/build.gradle
  • examples/uni-temporal-project/build.gradle
  • examples/unit-test-project/README.md
  • examples/unit-test-project/gradle.properties
  • examples/use-modulesdb-project/build.gradle
  • gradle.properties
  • gradle/wrapper/gradle-wrapper.jar
  • gradle/wrapper/gradle-wrapper.properties
  • gradlew
  • gradlew.bat
  • ml-app-deployer/build.gradle
  • ml-app-deployer/src/test/resources/sample-app/temporal-config-with-lsqt/databases/other-sample-app-content/temporal/collections/lsqt/temporal-collection.xml
  • ml-gradle/build.gradle
  • ml-gradle/src/main/groovy/com/marklogic/gradle/task/NewProjectTask.groovy
  • ml-gradle/src/main/groovy/com/marklogic/gradle/task/client/CopySearchOptionsTask.groovy
  • ml-javaclient-util/build.gradle

✅ Valid Files

  • NOTICE.txt
  • ml-app-deployer/src/main/java/com/marklogic/appdeployer/command/temporal/DeployTemporalCollectionsLSQTCommand.java
  • ml-app-deployer/src/main/java/com/marklogic/mgmt/util/ObjectMapperFactory.java
  • ml-app-deployer/src/test/java/com/marklogic/appdeployer/AbstractAppDeployerTest.java
  • ml-app-deployer/src/test/java/com/marklogic/appdeployer/command/temporal/DeployTemporalTest.java
  • ml-app-deployer/src/test/java/com/marklogic/rest/util/TestConfig.java

✅ All files have valid copyright headers!

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR merges release branch 6.1.0 into master, bumping the version from 6.0.x to 6.1.0 and updating dependencies. The release focuses on dependency upgrades, deprecating a conflicting property, and improving temporal collection handling.

Key changes:

  • Version updates across the project (6.0.x → 6.1.0)
  • Dependency upgrades including marklogic-client-api (7.2.0 → 8.0.0), Jackson (2.19.0 → 2.20.0), and OkHttp (4.12.0 → 5.2.0)
  • Deprecated group property in favor of groupName in CopySearchOptionsTask to avoid conflicts
  • Enhanced temporal collection LSQT configuration support with XML format and improved test coverage

Reviewed Changes

Copilot reviewed 59 out of 61 changed files in this pull request and generated no comments.

Show a summary per file
File Description
gradle.properties Updates project version to 6.1.0 and Jackson to 2.20.0
ml-javaclient-util/build.gradle Upgrades marklogic-client-api to 8.0.0 and adds JAXB compile dependency
ml-gradle/build.gradle Updates comment about marklogic-unit-test-client compilation version
ml-app-deployer/build.gradle Upgrades OkHttp to 5.2.0, commons-lang3 to 3.19.0, marklogic-junit5 to 2.0-SNAPSHOT, and adds JAXB dependencies
ml-gradle/src/main/groovy/com/marklogic/gradle/task/client/CopySearchOptionsTask.groovy Deprecates group property in favor of groupName with backward compatibility
ml-gradle/src/main/groovy/com/marklogic/gradle/task/NewProjectTask.groovy Updates version string to 6.1.0 in generated build.gradle
ml-app-deployer/src/main/java/com/marklogic/mgmt/util/ObjectMapperFactory.java Replaces deprecated setSerializationInclusion with setDefaultPropertyInclusion
ml-app-deployer/src/main/java/com/marklogic/appdeployer/command/temporal/DeployTemporalCollectionsLSQTCommand.java Improves filename parsing to use lastIndexOf for extracting collection names
ml-app-deployer/src/test/resources/sample-app/temporal-config-with-lsqt/databases/other-sample-app-content/temporal/collections/lsqt/ Replaces JSON LSQT config with XML format including lag property
ml-app-deployer/src/test/java/com/marklogic/appdeployer/command/temporal/DeployTemporalTest.java Adds verification that LSQT properties are correctly deployed to content database
ml-app-deployer/src/test/java/com/marklogic/appdeployer/AbstractAppDeployerTest.java Adds overloaded newDatabaseClient method accepting custom port
ml-app-deployer/src/test/java/com/marklogic/rest/util/TestConfig.java Replaces local RetryInterceptor with RetryIOExceptionInterceptor from client API
ml-app-deployer/src/test/java/com/marklogic/rest/util/RetryInterceptor.java Removes local retry interceptor implementation
gradlew, gradlew.bat Updates Gradle wrapper scripts to latest version
gradle/wrapper/gradle-wrapper.properties Updates Gradle distribution to 8.14.3 with additional validation properties
examples/**/build.gradle Updates ml-gradle plugin version to 6.1.0 across all example projects
NOTICE.txt Updates dependency versions and license information including corrected Jaxen license
.copyrightconfig Expands excluded files pattern to include test resources and markdown files

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@rjrudin rjrudin merged commit c50f52d into master Oct 15, 2025
3 checks passed
@rjrudin rjrudin deleted the release/6.1.0 branch October 15, 2025 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants