Skip to content

Conversation

@ahumphreys87
Copy link
Member

We'd need to update radio, metal, and babysitter, but this is just a start to check out the failing tests and begin the conversation of what it might look like to have the latest dependencies for the v3 launch.

would resolve #2446

Opening in favour of #2555

This was referenced May 16, 2015
@paulfalgout
Copy link
Member

So these failing tests must be fixed here jashkenas/backbone#3613 correct?

@ahumphreys87
Copy link
Member Author

I believe that is the real fix - however we can make our tests bypass this
code in backbone by enabling pushState on the router - do we wanna do that
in our tests? Would allow us to get this released - pretty confident it's
jsDom specific

On Monday, 18 May 2015, Paul Falgout [email protected] wrote:

So these failing tests must be fixed here jashkenas/backbone#3613
jashkenas/backbone#3613 correct?


Reply to this email directly or view it on GitHub
#2561 (comment)
.

@paulfalgout
Copy link
Member

I'll feel better when 1.2.1 comes out fixing:
jashkenas/backbone#3603
jashkenas/backbone#3615

But I don't know that it is worth waiting on either..

@paulfalgout
Copy link
Member

I think maybe we should go with 1.0.0 - ~1.2 for backbone. perhaps even 1.4.4 - ~1.8 for underscore.

There will likely be some 1.2 patch fixes in the near future. But there's more discussion about a Bb 2.0 than a 1.3, so rather than have to manage dependencies for the next few month, I'd bet it'd be safe to go this ~ route.

For that matter even ~1 for Bb

@ahumphreys87
Copy link
Member Author

If we do that we are relying on BB not releasing anything breaking in a minor or patch. Should we risk that?

@paulfalgout
Copy link
Member

And there we have it. Bb 1.2.1 released.

Time to update all the dependencies

@ahumphreys87
Copy link
Member Author

Awesome I'll update the deps. How do you feel about us updating wreqr to
support latest BB in 2.x @paulfalgout? I think we should tbh - 3.0 looks a
while away still and we don't want to block people

On Friday, 5 June 2015, Paul Falgout [email protected] wrote:

And there we have it. Bb 1.2.1 released.


Reply to this email directly or view it on GitHub
#2561 (comment)
.

@paulfalgout
Copy link
Member

agreed. those who can't upgrade to v3 quickly may still want to upgrade to Bb 1.2.1 and I don't see any reason to prevent that.

@ahumphreys87 ahumphreys87 force-pushed the update-dependencies branch 2 times, most recently from 9236c20 to 9367ef9 Compare June 8, 2015 19:53
@ahumphreys87 ahumphreys87 force-pushed the update-dependencies branch from 9367ef9 to 57b5464 Compare June 8, 2015 19:55
@ahumphreys87
Copy link
Member Author

bumped backbone to 1.2.1 and rebased.

Once this is in ill cherry-pick onto 2.4.2

@ahumphreys87 ahumphreys87 mentioned this pull request Jun 8, 2015
@paulfalgout
Copy link
Member

This is great once:

And for next we'll really need to update metal.

@ahumphreys87
Copy link
Member Author

I checked metal and it seemed ok. Not specific like ours though.

On Monday, 8 June 2015, Paul Falgout [email protected] wrote:

This is great once:

And for next we'll really need to update metal.


Reply to this email directly or view it on GitHub
#2561 (comment)
.

@ianmstew
Copy link
Member

ianmstew commented Jun 9, 2015

Agree this is much needed in 2.4.2. With all tests passing I don't see any reason not to merge. 👍

paulfalgout added a commit that referenced this pull request Jun 9, 2015
@paulfalgout paulfalgout merged commit afc177f into marionettejs:next Jun 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants