refactor(fp): v0.1.1 of notebook 05_functors.py #68
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
Use uppercased letters for
Generic
types, e.g.A = TypeVar("A")
Refactor the
Functor
class, changingfmap
and utility methods toclassmethod
For example:
Move the
check_functor_law
method fromFunctor
class to a standard functionListWrapper
toList
for simplicityJust
class📋 Checklist
--sandbox
README.md