-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Landing page for the repo #67
Conversation
… functional programming, optimization, probability, and Python. Enhance HTML content and ensure consistency in asset management.
…, including functional programming, optimization, and probability. Adjust descriptions, enhance user configurations, and ensure consistent theming for improved user experience.
… better theming and user experience. Clean up descriptions, implement light/dark mode support, and refine course display logic with improved search functionality.
…n and local testing.
…ng visual effects during toggling. Introduce closing animations for inactive courses and staggered appearance for notebooks to enhance user experience.
…d accessibility and user experience.
You should gitignore the _site directory to avoid committing build files |
Ahh my bad 🙈 |
…he new default theme and enhance theme toggle functionality.
}); | ||
</script> | ||
</body> | ||
</html>""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could this be in a separate html? maybe using jinja or just str.format()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I refactored the HTML generation to use separate modular functions that return relevant strings w/ format() approach rather than w/ jinja. They all assemble to the final HTML by concatenating these components. Is this fine?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yea we can pull out to proper html later if it gets difficult to maintain
…erests to use single quotes for consistency.
…at) into dedicated functions for better readability and maintainability.
📝 Summary
This PR introduces a landing page for the Learn repository with a modern, interactive UI inspired by Neon Genesis Evangelion aesthetics.
learn-landing-page-demo.mp4
📋 Checklist
--sandbox
README.md