Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Landing page for the repo #67

Merged
merged 14 commits into from
Mar 20, 2025
Merged

Landing page for the repo #67

merged 14 commits into from
Mar 20, 2025

Conversation

Haleshot
Copy link
Collaborator

📝 Summary

This PR introduces a landing page for the Learn repository with a modern, interactive UI inspired by Neon Genesis Evangelion aesthetics.

learn-landing-page-demo.mp4

📋 Checklist

  • I have included package dependencies in the notebook file using --sandbox
  • If adding a course, include a README.md
  • Keep language direct and simple.

Haleshot added 10 commits March 14, 2025 17:34
… functional programming, optimization, probability, and Python. Enhance HTML content and ensure consistency in asset management.
…, including functional programming, optimization, and probability. Adjust descriptions, enhance user configurations, and ensure consistent theming for improved user experience.
… better theming and user experience. Clean up descriptions, implement light/dark mode support, and refine course display logic with improved search functionality.
…ng visual effects during toggling. Introduce closing animations for inactive courses and staggered appearance for notebooks to enhance user experience.
@Haleshot Haleshot added the enhancement New feature or request label Mar 16, 2025
@Haleshot Haleshot self-assigned this Mar 16, 2025
@Haleshot Haleshot changed the title Haleshot/add docs page Landing page for the repo Mar 16, 2025
@mscolnick
Copy link
Contributor

You should gitignore the _site directory to avoid committing build files

@Haleshot
Copy link
Collaborator Author

You should gitignore the _site directory to avoid committing build files

Ahh my bad 🙈

});
</script>
</body>
</html>"""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could this be in a separate html? maybe using jinja or just str.format()

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I refactored the HTML generation to use separate modular functions that return relevant strings w/ format() approach rather than w/ jinja. They all assemble to the final HTML by concatenating these components. Is this fine?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yea we can pull out to proper html later if it gets difficult to maintain

mscolnick
mscolnick previously approved these changes Mar 18, 2025
…erests to use single quotes for consistency.
…at) into dedicated functions for better readability and maintainability.
@Haleshot Haleshot merged commit a488e86 into main Mar 20, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants