Landing page for the repo #67
Merged
+1,676
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… functional programming, optimization, probability, and Python. Enhance HTML content and ensure consistency in asset management.
…, including functional programming, optimization, and probability. Adjust descriptions, enhance user configurations, and ensure consistent theming for improved user experience.
… better theming and user experience. Clean up descriptions, implement light/dark mode support, and refine course display logic with improved search functionality.
…n and local testing.
…ng visual effects during toggling. Introduce closing animations for inactive courses and staggered appearance for notebooks to enhance user experience.
…d accessibility and user experience.
|
You should gitignore the _site directory to avoid committing build files |
Ahh my bad 🙈 |
…he new default theme and enhance theme toggle functionality.
mscolnick
reviewed
Mar 18, 2025
| }); | ||
| </script> | ||
| </body> | ||
| </html>""" |
There was a problem hiding this comment.
could this be in a separate html? maybe using jinja or just str.format()
There was a problem hiding this comment.
I refactored the HTML generation to use separate modular functions that return relevant strings w/ format() approach rather than w/ jinja. They all assemble to the final HTML by concatenating these components. Is this fine?
There was a problem hiding this comment.
yea we can pull out to proper html later if it gets difficult to maintain
mscolnick
previously approved these changes
Mar 18, 2025
…erests to use single quotes for consistency.
…at) into dedicated functions for better readability and maintainability.
mscolnick
approved these changes
Mar 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
This PR introduces a landing page for the Learn repository with a modern, interactive UI inspired by Neon Genesis Evangelion aesthetics.
learn-landing-page-demo.mp4
📋 Checklist
--sandboxREADME.md