-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Bug 1935232 [wpt PR 49528] - Update dialog closedby behavior to only …
…close one at a time, a=testonly Automatic update from web-platform-tests Update dialog closedby behavior to only close one at a time Per the discussions at: - openui/open-ui#1128 - whatwg/html#9373 (comment) both developer and editor feedback is that the prior behavior was a bit odd. In the case where there are "nested" dialogs, the desired behavior is for light dismiss clicks to just pop the topmost dialog off the stack, rather than trying to close all non-clicked dialogs. This CL implements that behavior and updates the test. After implementing this behavior and playing with it a bit, I agree with the feedback - this feels more like what users would expect. Once this lands and I get a bit of feedback, I'll incorporate this into the spec PR. Bug: 376516550 Change-Id: I4b5cfb7dd4a27fc304e52759d882b47394e55524 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6068807 Commit-Queue: David Baron <dbaronchromium.org> Auto-Submit: Mason Freed <masonfchromium.org> Reviewed-by: David Baron <dbaronchromium.org> Cr-Commit-Position: refs/heads/main{#1391794} -- wpt-commits: e96c4c3d5c6510202598f558ea520b80f9507b31 wpt-pr: 49528 UltraBlame original commit: 4079bdd253f749bea402e22f1929ca53a25c228b
- Loading branch information
Showing
1 changed file
with
108 additions
and
64 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters