Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the return type of the merge Method and modify the existinf spec by reference. #59

Merged
merged 2 commits into from
Mar 21, 2025

Conversation

marcelthole
Copy link
Owner

This will reduce the time for loading over 1500 Spec files from 2 minutes to 1 second.

new - fixtures contains 1500 files

/var/www # time php bin/openapi-merge fixtures/api.openapi.json --resolve-references=0 -- $(find fixtures/ -type f -iname '*.openapi.json' | xargs) > /dev/null
real    0m 0.86s
user    0m 0.67s
sys     0m 0.18s

old - fixtures contains 1500 files

/var/www # time php bin/openapi-merge fixtures/api.openapi.json --resolve-references=0 -- $(find fixtures/ -type f -iname '*.openapi.json' | xargs) > /dev/null
real    2m 2.03s
user    2m 0.82s
sys     0m 1.16s

…ec by reference. This will reduce the time for loading over 1500 Spec files from 2 minutes to 1 second
@marcelthole marcelthole merged commit eaa10fb into main Mar 21, 2025
7 checks passed
@marcelthole marcelthole deleted the improve-merge-perfomance branch March 21, 2025 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant