gpx: implement extensions #278
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgillich
commented
Oct 29, 2025
| <sat>9</sat> | ||
| <extensions> | ||
| <gpxtpx:TrackPointExtension | ||
| xmlns:gpxtpx="http://www.garmin.com/xmlschemas/TrackPointExtension/v1"> |
Collaborator
Author
There was a problem hiding this comment.
xmlutil quirk: namespace declarations are added to each element instead of the root only. There is a isCollectingNSAttributes config option to configure this, but it does not seem to work for dynamic namespaces in Elements
jgillich
commented
Oct 29, 2025
|
|
||
| // ElementSerializer doesn't work in NodeJS because DOMParser is only available in browser | ||
| // https://github.com/pdvrieze/xmlutil/issues/298 | ||
| tasks.named("jsNodeTest") { enabled = false } |
Collaborator
Author
There was a problem hiding this comment.
We could polyfill DOMParser on node like
import { DOMParser } from 'xmldom';
global.DOMParser = DOMParser;But I failed to get that set up. Maybe another time
sargunv
approved these changes
Oct 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I didn't go the generics route because you'd have to provide like 10 type args to the decoder. Instead it uses xmlutil's
Element(the equivalent ofJsonObject)The gpx module should be pretty much feature complete now