Less strict gpx decoding #275
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Parse files without schemaLocation, creator or timezones
To match naming on track
sargunv
approved these changes
Oct 27, 2025
| import kotlinx.serialization.encoding.Encoder | ||
|
|
||
| @OptIn(ExperimentalTime::class) | ||
| internal object InstantSerializer : KSerializer<Instant> { |
There was a problem hiding this comment.
I'd name it for the specific intended format, like Iso8601InstantSerializer in this case.
Though I'm curious, does the default serializer not do the same format?
There was a problem hiding this comment.
Ah I see the offset component is optional here.
So I'd name it with that, like UtcDefaultInstantSerializer or something along those lines
There was a problem hiding this comment.
Yea, Instant doesn't parse without offsets and LocalDateTime doesn't parse with offsets. Pretty annoying
Renamed to UtcDefaultInstantSerializer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parse files without schemaLocation, creator or timezones