Skip to content

chore(ci): move docker testing to just#2496

Draft
CommanderStorm wants to merge 7 commits intomaplibre:mainfrom
CommanderStorm:move-docker-testing-to-just
Draft

chore(ci): move docker testing to just#2496
CommanderStorm wants to merge 7 commits intomaplibre:mainfrom
CommanderStorm:move-docker-testing-to-just

Conversation

@CommanderStorm
Copy link
Member

this PR pulls the resonably problemnatic move from CI-bash to just-bash from

Copilot AI review requested due to automatic review settings January 12, 2026 05:09
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors Docker integration testing by moving the test configuration from inline bash scripts in the CI workflow to reusable just recipes. The change improves maintainability by centralizing Docker test logic in the justfile rather than duplicating it across CI workflow steps.

Changes:

  • Created two new just recipes (run-in-docker-image and test-int-in-docker-image) to encapsulate Docker test execution
  • Simplified CI workflow by replacing repetitive inline bash blocks with concise just command invocations
  • Enhanced test-lambda recipe with GitHub Actions grouping for better CI output organization

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
justfile Added run-in-docker-image helper recipe to run binaries in Docker containers, added test-int-in-docker-image recipe to orchestrate integration tests against Docker images, improved test-lambda with output grouping, and fixed comment formatting
.github/workflows/ci.yml Replaced verbose inline Docker test commands with clean just recipe calls, and added installation of just and cargo-sqlx tools required for the new approach

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@CommanderStorm CommanderStorm marked this pull request as draft January 12, 2026 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants