chore(ci): move docker testing to just#2496
Draft
CommanderStorm wants to merge 7 commits intomaplibre:mainfrom
Draft
chore(ci): move docker testing to just#2496CommanderStorm wants to merge 7 commits intomaplibre:mainfrom
CommanderStorm wants to merge 7 commits intomaplibre:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors Docker integration testing by moving the test configuration from inline bash scripts in the CI workflow to reusable just recipes. The change improves maintainability by centralizing Docker test logic in the justfile rather than duplicating it across CI workflow steps.
Changes:
- Created two new just recipes (
run-in-docker-imageandtest-int-in-docker-image) to encapsulate Docker test execution - Simplified CI workflow by replacing repetitive inline bash blocks with concise just command invocations
- Enhanced
test-lambdarecipe with GitHub Actions grouping for better CI output organization
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| justfile | Added run-in-docker-image helper recipe to run binaries in Docker containers, added test-int-in-docker-image recipe to orchestrate integration tests against Docker images, improved test-lambda with output grouping, and fixed comment formatting |
| .github/workflows/ci.yml | Replaced verbose inline Docker test commands with clean just recipe calls, and added installation of just and cargo-sqlx tools required for the new approach |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
CommanderStorm
commented
Jan 12, 2026
CommanderStorm
commented
Jan 12, 2026
CommanderStorm
commented
Jan 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this PR pulls the resonably problemnatic move from CI-bash to just-bash from