Skip to content

Conversation

@melitele
Copy link
Contributor

@melitele melitele commented Nov 3, 2025

Launch Checklist

Implements #6495

  • Confirm your changes do not include backports from Mapbox projects (unless with compliant license) - if you are not sure about this, please ask!
  • Briefly describe the changes in this PR.
  • Link to related issues.
  • Write tests for all new functionality.
  • Document any changes to public APIs.
  • Add an entry to CHANGELOG.md under the ## main section.

@HarelM
Copy link
Collaborator

HarelM commented Nov 3, 2025

Is this considered a style spec change?
Cc: @louwers

@louwers
Copy link
Member

louwers commented Nov 3, 2025

Native doesn't support this yet so as far as Native is concerned changes are not a problem.

@HarelM
Copy link
Collaborator

HarelM commented Nov 4, 2025

There should probably a design proposal issue instead of this PR to discuss this, but as far as I understand this change, it might mean that every feature can change the visibility of a layer?
If so, it's problematic.
This is not a minor change to the spec to change how visibility is behaving, so I think a proper discussion (design proposal issue) is needed here.

@melitele
Copy link
Contributor Author

melitele commented Nov 4, 2025

... every feature can change the visibility of a layer?

Of course not, this is what filters are for.

This PR makes visibility dependent only on global state as per #6495

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants