Added fix for jupyter console problem. - #1241
Open
SilkeSchomann wants to merge 4 commits into
Open
Conversation
SilkeSchomann
force-pushed
the
1235_jupyter_console
branch
from
September 3, 2026 07:07
dc99c3c to
1d4601b
Compare
SilkeSchomann
force-pushed
the
1235_jupyter_console
branch
from
September 3, 2026 10:35
1a86f41 to
986bfee
Compare
for more information, see https://pre-commit.ci
Collaborator
Author
|
The pixi workflows are failing due to an update problem with the pixi lockfile. This has nothing to do with the changes made for this PR. The pixi lockfile problem gets solved by this PR: #1242. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of work:
Added find_workbench_kernel_manager(), which looks for Workbench's already-running console widget and reuses its kernel manager (attaching MSlice's console as an additional frontend of the same kernel, instead of starting a competing one). Falls back to the old standalone behaviour when no Workbench console exists. cleanup() now also properly detaches MSlice's own client from the kernel's frontends list on close (and only shuts the kernel down if MSlice owns it), so Workbench's console is left completely untouched.
To test:
Follow the instructions on the original GitHub issues.
Fixes #1235.