Set parent windows on dialogs so they are transient for their owning … - #1183
Open
daym wants to merge 1 commit into
Open
Set parent windows on dialogs so they are transient for their owning …#1183daym wants to merge 1 commit into
daym wants to merge 1 commit into
Conversation
…application windows.
Contributor
Author
|
I can explain further if needed. Basically, it just sets the parent window of the dialogs so the system knows what dialog is [requested for] for what window. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… application windows.
Description of work:
This PR sets a parent window on all dialogs so they are transient for their owning application windows, which means they will be shown together close to their application windows--and not somewhere else, or, the other extreme, just obscuring the entire application window they belong to.
To test:
Open the respective dialog window on a big screen. You'll see each dialog now is a (smaller) popup centered over the owning application window and stays close to it.