fix: implement end marker logic for joined fields in SQL source iteration #3881
+85
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion Related issue #3864
4 tasks
tomatolog
requested changes
Nov 2, 2025
There was a problem hiding this comment.
it could be better to refactor the ProcessCollectedHits function and use it here along with CSphSource::BuildHits as that function could handle blended hits but this function missed this case with the blended. And it could be better to has the single code (ProcessCollectedHits) there all bugs could be fixed at once instead of fix the possible bug at the ProcessCollectedHits then at CSphSource_SQL::IterateJoinedHits
Related issue #3864
- Moved ProcessCollectedHits to a public method in CSphSource, removing unnecessary parameters. - Updated references to use member variables directly, improving clarity and maintainability. - Adjusted logic in SQL source iteration to utilize the new ProcessCollectedHits method for handling blended hits and setting end markers.
…ts sequence - Introduced FindBlendedHitsStart method to encapsulate logic for finding the start index of the last blended hits sequence in joined field hits. - Updated IterateJoinedHits to utilize the new method, improving code clarity and maintainability.
Done. Pls review. |
Windows test results 3 files 3 suites 26m 2s ⏱️ For more details on these failures, see this check. Results for commit 57c9ac2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue #3864