-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Add the cmux Max plan and gate 32 GB and 64 GB machines behind it #12309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
lawrencecchen
wants to merge
19
commits into
main
Choose a base branch
from
feat-max-plan
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
58dccdb
Add the Max plan constants and the per-plan machine memory ceiling
lawrencecchen 6471dc0
Sell Max through Stripe and label personal subscriptions by their Price
lawrencecchen 75cc227
Add the Max card and column to every pricing page
lawrencecchen 092b198
Show locked 32 GB and 64 GB sizes with a Max upgrade in the Mac app
lawrencecchen 6ac69da
Test the Max checkout, portal switch, plan route, and memory gate; ke…
lawrencecchen d2ada70
Add Max plan unit tests and record the live Stripe ids
lawrencecchen 367fcca
Merge remote-tracking branch 'origin/main' into feat-max-plan
lawrencecchen d8bbce4
test: cover Max upgrades for Founder and Team accounts
lawrencecchen 99eb5bd
test: reject oversized copied machines before provisioning
lawrencecchen 1727671
feat: enforce Max VM sizing and add authenticated CLI checkout
lawrencecchen ec9b1b9
fix: tighten Max size telemetry and workflow typing
lawrencecchen ad328a2
chore: complete Max localization and CLI help
lawrencecchen 03ab86e
fix: show Max billing price in dashboard
lawrencecchen ad69d08
docs: describe VM resources per machine
lawrencecchen 5ad78f6
fix: keep Team entitlements scoped while honoring personal Max
lawrencecchen 42b400d
docs: clarify per-VM resource limits
lawrencecchen a2815cc
fix: remove duplicate dashboard plan binding
lawrencecchen 68b8934
fix: keep VM upgrade telemetry values type safe
lawrencecchen 4d4bb0c
fix: correct Max resource copy in all pricing views
lawrencecchen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
Localize the new Max and VM-memory copy.
Japanese CLI and socket users receive these new messages only in English. Move the new strings into the existing localization mechanism and add entries for every supported locale.
CLI/CMUXCLI+VMTransfer.swift#L1002-L1003: localize thevm runsize help.Sources/Cloud/VMClientSocketCommands.swift#L27-L28: localize the checkout validation message.CLI/CMUXCLI+VMTransfer.swift#L1074-L1074: localize thevm runinvalid-size error.CLI/CMUXCLI+VMTransfer.swift#L1519-L1520: localize thevm routesize help.CLI/CMUXCLI+VMTransfer.swift#L1565-L1566: localize thevm agentsize help.CLI/CMUXCLI+VMTransfer.swift#L1669-L1669: localize thevm routeinvalid-size error.CLI/CMUXCLI+VMTransfer.swift#L1768-L1768: localize thevm agentinvalid-size error.📍 Affects 2 files
CLI/CMUXCLI+VMTransfer.swift#L1002-L1003(this comment)Sources/Cloud/VMClientSocketCommands.swift#L27-L28CLI/CMUXCLI+VMTransfer.swift#L1074-L1074CLI/CMUXCLI+VMTransfer.swift#L1519-L1520CLI/CMUXCLI+VMTransfer.swift#L1565-L1566CLI/CMUXCLI+VMTransfer.swift#L1669-L1669CLI/CMUXCLI+VMTransfer.swift#L1768-L1768🤖 Prompt for AI Agents
Sources: Coding guidelines, Path instructions