Attempt to have arrow_array_private_data owning and non owning buffers#632
Draft
Hind-M wants to merge 3 commits intoman-group:mainfrom
Draft
Attempt to have arrow_array_private_data owning and non owning buffers#632Hind-M wants to merge 3 commits intoman-group:mainfrom
arrow_array_private_data owning and non owning buffers#632Hind-M wants to merge 3 commits intoman-group:mainfrom
Conversation
Collaborator
|
@Hind-M Do you plan to continu this PR? how can I help you ? |
Collaborator
Author
Yes this work would be resumed at some point, but not in the coming days. So if you feel like taking over, you can totally do so :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
sparrow-ipc, we are duplicating code fromsparrow(seesparrow-ipc/src/arrow_interfaceandsparrow-ipc/include/sparrow_ipc/arrow_interfacefolders) becausesparrowonly allowsarrow_array_private_datato own buffers while it could be non owning insparrow-ipc.This PR is giving a first glimpse of what may be changed to avoid this code duplication.
Note that this is still unfinished work (not building and not cleaned/reviewed).
If we decide to continue with this strategy, further work would be needed.
cf. sparrow-org/sparrow-ipc#40