Speed up version_chain benchmarks setup_cache #2833
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poodlewars
added
patch
Collaborator
|
Nice idea to speed it up. |
IvoDD
requested changes
Jan 5, 2026
python/benchmarks/version_chain.py
Outdated
|
|
||
| adb._ext.unset_config_int("VersionMap.ReloadInterval") | ||
| shutil.rmtree("version_chain_deleted", ignore_errors=True) | ||
| shutil.copytree("version_chain", "version_chain_tail_deleted") |
Collaborator
There was a problem hiding this comment.
We're removing version_chain_deleted but copying to version_chain_tail_deleted.
Maybe add constants for directory names so it's harder to make such error:
DIR_UNDELETED = "version_chain"
DIR_TAIL_DELETED = "version_chain_tail_deleted"
CONNECTION_STRING_UNDELETED = f"lmdb://{DIR_UNDELETED}"
CONNECTION_STRING_TAIL_DELETED = f"lmdb://{DIR_TAIL_DELETED}"
python/benchmarks/version_chain.py
Outdated
| assert len(lib.list_versions(symbol)) == num_versions - deletion_point | ||
|
|
||
| adb._ext.unset_config_int("VersionMap.ReloadInterval") | ||
| print("IterateVersionChain: Setup cache took (s) :", time.time() - start_time, file=sys.stderr) |
Collaborator
There was a problem hiding this comment.
Nit: We're printing the time two times. Here and in setup_cache. Maybe just keep one?
| if deleted: | ||
| ac = Arctic(IterateVersionChain.CONNECTION_STRING_UNDELETED) | ||
| else: | ||
| ac = Arctic(IterateVersionChain.CONNECTION_STRING_TAIL_DELETED) |
Collaborator
There was a problem hiding this comment.
Maybe if and else should be the other way round?
IvoDD
approved these changes
Jan 6, 2026
python/benchmarks/version_chain.py
Outdated
| assert len(lib.list_versions(symbol)) == num_versions - deletion_point | ||
|
|
||
| adb._ext.unset_config_int("VersionMap.ReloadInterval") | ||
| print("IterateVersionChain: Setup cache took (s) :", time.time() - start_time, file=sys.stderr) |
Collaborator
There was a problem hiding this comment.
Nit: Also remove the corresponding start time
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The setup_cache creates two libraries, one with the tail of the version chain deleted. We used to write both libraries with Arctic APIs.
I change it here to write most of the versions of one library with Arctic APIs, up to the point where we want to delete the symbol, then copy that state with
shutil.copytree. This roughly halves the amount of time spent insetup_cache, from ~17 minutes down to ~8 on my machine.I also change the benchmarks to control their number of runs with
sample_timerather thannumber. The high number was introduced for some benchmarks that run very quickly and so are noisy, but doing that across all the benchmarks isn't suitable as others are slow and stable.