Python 3.14 GIL version support for pypi #2828
Conversation
phoebusm
requested review from
IvoDD,
alexowens90 and
poodlewars
as code owners
phoebusm
force-pushed
the
feature/pypi_3.14
branch
2 times, most recently
from
5b70231 to
8925920
Compare
| if [[ "${{env.python_impl_name}}" == "cp313" ]]; then | ||
| echo /opt/python/cp313-cp313/bin >> $GITHUB_PATH; | ||
| elif [[ "${{env.python_impl_name}}" == "cp314" ]]; then | ||
| echo /opt/python/cp314-cp314/bin >> $GITHUB_PATH; |
There was a problem hiding this comment.
Does 3.14 have the t variant as well? If so, comment on line 516 should be updated. If not, this will be handled in the else
| subversion = python_version[1:] | ||
|
|
||
| assert subversion in ["6", "7", "8", "9", "10", "11", "12", "13"], python_version | ||
| assert subversion in ["6", "7", "8", "9", "10", "11", "12", "13", "14"], python_version |
There was a problem hiding this comment.
Presumably some of these lower numbers could be removed now
.git-blame-ignore-revs
Outdated
| 7acd347e3a035b635fd71c1bde2b54e0135ac8db | ||
|
|
||
| # Formating for upgrading Black to 25.11.0 | ||
| 26da22114eaadb29fea55af141246e4855ac4879 |
There was a problem hiding this comment.
Annoyingly this hash will (almost certainly) change when you rebase+merge, so needs to be added in a separate PR
There was a problem hiding this comment.
I think that is not the case if the PR doesn't require rebase and not being squashed 🤔
There was a problem hiding this comment.
Rebase and merge on GitHub will always update the committer information and create new commit SHAs 😞
|
Remember not to click the default "Squash and merge"! |
phoebusm
force-pushed
the
feature/pypi_3.14
branch
from
8925920 to
b1e236d
Compare
vasil-pashov
left a comment
vasil-pashov
left a comment
There was a problem hiding this comment.
Python 3.14 has a GIL-free version. We should note that the GIL-free version is not officially supported yet.
phoebusm
changed the title
phoebusm
force-pushed
the
feature/pypi_3.14
branch
from
b1e236d to
f7f8dde
Compare
phoebusm
force-pushed
the
feature/pypi_3.14
branch
from
f7f8dde to
265a34c
Compare
Reference Issues/PRs
https://man312219.monday.com/boards/7852509418/pulses/10841098210
What does this implement or fix?
blackis needed to updated to support python 3.14Any other comments?
Wheels are successfully built here: https://github.com/man-group/ArcticDB/actions/runs/20576772471/attempts/1
No work is needed for python 3.14 release for conda is already available there: https://anaconda.org/channels/conda-forge/packages/arcticdb/files?name=py314
Checklist
Checklist for code changes...